Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trino to 448 #161

Merged
merged 5 commits into from
May 18, 2024
Merged

Update Trino to 448 #161

merged 5 commits into from
May 18, 2024

Conversation

nineinchnick
Copy link
Member

Also, update the chart version to trigger a new release.

@nineinchnick nineinchnick requested a review from wendigo May 12, 2024 09:28
@cla-bot cla-bot bot added the cla-signed label May 12, 2024
@mosabua
Copy link
Member

mosabua commented May 13, 2024

Don't we have to update the JVM config that comes out of the box with the chart or is this cleanly only using the one from the container and updating that..

If we update and merge this .. will the chart still be working with earlier releases .. given the current change I think the answer is yes.. but can you confirm?

@nineinchnick
Copy link
Member Author

If we update and merge this .. will the chart still be working with earlier releases .. given the current change I think the answer is yes.. but can you confirm?

This is a great idea for another test in the CI!

@wendigo
Copy link
Contributor

wendigo commented May 16, 2024

448 was released, please update @nineinchnick

@nineinchnick nineinchnick changed the title Update Trino to 447 Update Trino to 448 May 16, 2024
@nineinchnick nineinchnick force-pushed the update-app branch 2 times, most recently from ca41467 to 64a214d Compare May 16, 2024 11:29
@nineinchnick
Copy link
Member Author

@wendigo PTAL, especially on the JVM flags update.

We can now add more complex tests, enabling more/most features supported in the chart.

@mosabua
Copy link
Member

mosabua commented May 16, 2024

This looks good but are you sure you want this order of commits? Typically I think its easier to do the release update/tagging as a separate PR.

@nineinchnick
Copy link
Member Author

@mosabua I made sure the version bump commit is the last one, esp. after running all tests.

@nineinchnick nineinchnick merged commit c7d1904 into trinodb:main May 18, 2024
8 checks passed
@nineinchnick nineinchnick deleted the update-app branch May 18, 2024 08:22
@wendigo
Copy link
Contributor

wendigo commented May 18, 2024

We need to add a workaround for the g1 pinning issue @nineinchnick

@nineinchnick
Copy link
Member Author

What workaround?

@nineinchnick
Copy link
Member Author

I cancelled the release workflow: https://github.com/trinodb/charts/actions/runs/9138540987

@wendigo
Copy link
Contributor

wendigo commented May 18, 2024

trinodb/trino#21999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants