-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Trino to 448 #161
Update Trino to 448 #161
Conversation
Don't we have to update the JVM config that comes out of the box with the chart or is this cleanly only using the one from the container and updating that.. If we update and merge this .. will the chart still be working with earlier releases .. given the current change I think the answer is yes.. but can you confirm? |
This is a great idea for another test in the CI! |
448 was released, please update @nineinchnick |
ca41467
to
64a214d
Compare
@wendigo PTAL, especially on the JVM flags update. We can now add more complex tests, enabling more/most features supported in the chart. |
This looks good but are you sure you want this order of commits? Typically I think its easier to do the release update/tagging as a separate PR. |
@mosabua I made sure the version bump commit is the last one, esp. after running all tests. |
We need to add a workaround for the g1 pinning issue @nineinchnick |
What workaround? |
I cancelled the release workflow: https://github.com/trinodb/charts/actions/runs/9138540987 |
Also, update the chart version to trigger a new release.