-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enable worker graceful shutdown #226
Add option to enable worker graceful shutdown #226
Conversation
58e7763
to
ebb5efa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I have some comments about making it even more robust, and not allowing users to make configuration mistakes.
Hello @nineinchnick, Thank you so much for finding the time to review this PR! |
Thanks! No rush and we can always chat on the Trino slack if anything is not clear enough |
ebb5efa
to
84d69aa
Compare
Dear @nineinchnick, I have addressed all your comments. Regarding the test implementation, I considered using a long-running query; however, I was uncertain about its appropriateness as it seemed more like a Trino test than a Helm Chart test. Ultimately, my testing approach involves deleting a worker pod using Looking forward to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great now, thanks! Resolve the conflict and we can merge this.
4b782a0
to
35d729c
Compare
I rebased and addressed your last comment. Should be ready now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpick to get better docs.
35d729c
to
3ae5670
Compare
In this PR I have automated the process of enabling the Worker Graceful Shutdown feature.
Enabling the option will:
preStop
lifecycle event to all worker Pods;shutdown.grace-period
configuration property togracePeriod
;accessControl
since thedefault
system access control does not allow graceful shutdowns.I also added a test to check if the graceful shutdown endpoint can be successfully called on the worker Pods.
Fixes #189