Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to enable JMX exporter on workers #227

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add option to enable JMX exporter on workers #227

merged 1 commit into from
Oct 3, 2024

Conversation

sdaberdaku
Copy link
Member

Fixes #224

@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
@sdaberdaku sdaberdaku marked this pull request as ready for review September 26, 2024 11:01
@sdaberdaku sdaberdaku changed the title Add an option to enable JMX exporter on workers Add option to enable JMX exporter on workers Sep 26, 2024
@sdaberdaku sdaberdaku force-pushed the feature/worker-jmx-exporter-support branch from 54e6b89 to ffcda16 Compare September 26, 2024 11:04
@sdaberdaku
Copy link
Member Author

Hi @nineinchnick!
I was wondering if you could review this PR, whenever you get the chance!

Thanks!

Sebastian

nineinchnick
nineinchnick reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the general approach to this

test-values.yaml Show resolved Hide resolved
charts/trino/values.yaml Outdated Show resolved Hide resolved
test-values.yaml Outdated Show resolved Hide resolved
charts/trino/values.yaml Outdated Show resolved Hide resolved
@sdaberdaku sdaberdaku force-pushed the feature/worker-jmx-exporter-support branch 3 times, most recently from 11d92a8 to fd8ba50 Compare October 2, 2024 17:37
@sdaberdaku
Copy link
Member Author

Hello @nineinchnick,

I implemented the suggested changes.

I added a headless Service for worker Pods which serves as a target for a dedicated ServiceMonitor.
I added coordinator and worker blocks inside jmx and serviceMonitor so that users can override the respective configurations of the components.
I extended the existing JMX test to cover the changes that I made.
Finally, I made a slight change to test.sh and configured Prometheus to scrape only ServiceMonitors with a specific label (which is also set in test-values.yaml: serviceMonitor.labels.prometheus=default) - less entropy.

Let me know if you have any more comments!

nineinchnick
nineinchnick approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks SO much better, thank you! TIL about merge. Just a bunch of nitpick comments, but otherwise LGTM!

charts/trino/templates/tests/test-jmx.yaml Show resolved Hide resolved
charts/trino/templates/tests/test-jmx.yaml Outdated Show resolved Hide resolved
charts/trino/templates/tests/test-jmx.yaml Outdated Show resolved Hide resolved
test-values.yaml Show resolved Hide resolved
test.sh Show resolved Hide resolved
@sdaberdaku sdaberdaku force-pushed the feature/worker-jmx-exporter-support branch from fd8ba50 to 7fd0675 Compare October 3, 2024 08:56
@nineinchnick nineinchnick merged commit 1956935 into trinodb:main Oct 3, 2024
9 checks passed
@nineinchnick nineinchnick added the enhancement New feature or request label Oct 3, 2024
@rotem-ad rotem-ad mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineinchnick nineinchnick nineinchnick approved these changes

Assignees
No one assigned
Labels
cla-signed enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jmx Exports for Workers
2 participants
@sdaberdaku @nineinchnick