-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_separate_group.db_secret #231
add_separate_group.db_secret #231
Conversation
I was inspired by the #188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but it needs a test. Look at test.sh
and add a new test case with a separate values file. Thanks for working on this!
I'll check and make test during this week |
I changed group to goups almost in all cases. I still not sure what changes, and test cases you are talking about Could you provide more information about it? I really want to help here, but not sure how. |
Terrably sorry for this little typos. 😸 |
As the old joke says, the two hardest problems in IT are:
Let's figure out good names here together. |
e007e82
to
3a6b33b
Compare
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Hello!
I'm not very experienced with Trino configuration, but I do have a bit more experience with Helm charts.
The main question in this PR is determining the correct place to change the file.password-file and file.group-file configurations.
I placed them in a separate folder to keep automatic updates when k8s secrets are updated.
This approach contrasts with using subPath, which does not support automatic file updates within pod volumes.