Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templating support in additionalConfigFiles #240

Conversation

sdaberdaku
Copy link
Member

@sdaberdaku sdaberdaku commented Oct 3, 2024

With this feature we now can do sth like this:
In values.yaml

...
groupProvider:
  refreshPeriod: 60s
  groups:
    group_1:
      - user_1
      - user_2
      - user_3
    group_2:
      - user_4
...
coordinator:
  additionalConfigFiles:
    group-provider.properties: |-
      group-provider.name=file
      file.group-file={{ .Values.server.config.path }}/group-provider.db
      file.refresh-period={{ .Values.groupProvider.refreshPeriod }}

    group-provider.db: |-
      {{- range $k, $v := .Values.groupProvider.groups }}
      {{- printf "%s:%s\n" $k (join "," $v) }}
      {{- end }}

Closes #237

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@sdaberdaku sdaberdaku force-pushed the feature/templatable-additionalConfigFiles branch from e861379 to bea6abd Compare October 3, 2024 14:39
@sdaberdaku sdaberdaku force-pushed the feature/templatable-additionalConfigFiles branch from bea6abd to c4e51fc Compare October 3, 2024 14:41
@sdaberdaku sdaberdaku marked this pull request as ready for review October 3, 2024 15:02
@nineinchnick nineinchnick merged commit ece02db into trinodb:main Oct 3, 2024
9 checks passed
@nineinchnick nineinchnick added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Refactor auth.groups for easier management
2 participants