Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting annotations in deployments #256

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Support setting annotations in deployments #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/trino/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
secretName: sample-secret
path: /secrets/sample.json
```
* `coordinator.deployment.annotations` - object, default: `{}`
* `coordinator.deployment.progressDeadlineSeconds` - int, default: `600`

The maximum time in seconds for a deployment to make progress before it is considered failed. The deployment controller continues to process failed deployments and a condition with a ProgressDeadlineExceeded reason is surfaced in the deployment status.
Expand Down Expand Up @@ -520,6 +521,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
secretName: sample-secret
path: /secrets/sample.json
```
* `worker.deployment.annotations` - object, default: `{}`
* `worker.deployment.progressDeadlineSeconds` - int, default: `600`

The maximum time in seconds for a deployment to make progress before it is considered failed. The deployment controller continues to process failed deployments and a condition with a ProgressDeadlineExceeded reason is surfaced in the deployment status.
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ metadata:
{{- if .Values.coordinator.labels }}
{{- tpl (toYaml .Values.coordinator.labels) . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.coordinator.deployment.annotations | nindent 4 }}
spec:
progressDeadlineSeconds: {{ .Values.coordinator.deployment.progressDeadlineSeconds }}
revisionHistoryLimit: {{ .Values.coordinator.deployment.revisionHistoryLimit }}
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ metadata:
{{- if .Values.worker.labels }}
{{- tpl (toYaml .Values.worker.labels) . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.worker.deployment.annotations | nindent 4 }}
spec:
progressDeadlineSeconds: {{ .Values.worker.deployment.progressDeadlineSeconds }}
revisionHistoryLimit: {{ .Values.worker.deployment.revisionHistoryLimit }}
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ secretMounts: []

coordinator:
deployment:
annotations: {}
progressDeadlineSeconds: 600
# coordinator.deployment.progressDeadlineSeconds -- The maximum time in seconds for a deployment to make progress before it
# is considered failed. The deployment controller continues to
Expand Down Expand Up @@ -623,6 +624,7 @@ coordinator:

worker:
deployment:
annotations: {}
progressDeadlineSeconds: 600
# worker.deployment.progressDeadlineSeconds -- The maximum time in seconds for a deployment to make progress before it
# is considered failed. The deployment controller continues to
Expand Down
10 changes: 10 additions & 0 deletions test-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ secretMounts:

coordinator:
deployment:
annotations:
custom/name: value
progressDeadlineSeconds: 500
revisionHistoryLimit: 5
strategy:
Expand Down Expand Up @@ -82,8 +84,13 @@ coordinator:
port: 8443
protocol: TCP

annotations:
custom/name: value

worker:
deployment:
annotations:
custom/name: value
progressDeadlineSeconds: 500
revisionHistoryLimit: 5
strategy:
Expand All @@ -104,6 +111,9 @@ worker:
query:
maxMemoryPerNode: "2GB"

annotations:
custom/name: value

commonLabels:
extra-label: extra-value

Expand Down