Add envFrom and remove lookup #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/config-from-env
branch
from
6c552a3 to
be32f79
Compare
willmostly
force-pushed
the
will/config-from-env
branch
from
be32f79 to
ace7a57
Compare
nineinchnick
approved these changes
Dec 4, 2024
|
@willmostly please rebase |
willmostly
force-pushed
the
will/config-from-env
branch
from
ace7a57 to
0b0396f
Compare
nineinchnick
added
the
breaking-change
nineinchnick
approved these changes
Dec 10, 2024
|
Just a note - this is a breaking change, which reminded me that we should also clarify somewhere in the docs that the chart's version number is not following semantic versioning. |
|
We can just do that in the readme for the chart .. or in the page I will work on for the Trino Gateway docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
envFromto allow providing environment variables from Secrets, and remove usage of the Helmlookupfunction for merging Secrets into the configuration.This removes the custom checksum calculation as well. The checksum had included the optional configuration secrets, causing pod restarts whether configuration was updated through the chart or through a secret. Since this required retrieving Secrets from the target cluster through the Helm
lookupfunction, it caused the chart to be incompatible with release pipelines in which a manifest is generated in an environment that does not have access to the target cluster.