Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create secret if auth.passwordAuth is set #59

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

ryan0x44
Copy link
Contributor

@ryan0x44 ryan0x44 commented Dec 9, 2022

Problem: if users have a solution like Sealed Secrets which creates Secret objects at runtime from a Kubernetes controller, right now there's no easy way to use this instead of the default provided Secret template.

Solution: if the auth.passwordAuth value is not set, do not create a Secret, so that users can create their own secret containing the passwords.db file.

@cla-bot
Copy link

cla-bot bot commented Dec 9, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@martint
Copy link
Member

martint commented Dec 20, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2022
@cla-bot
Copy link

cla-bot bot commented Dec 20, 2022

The cla-bot has been summoned, and re-checked this pull request!

@ryan0x44
Copy link
Contributor Author

ryan0x44 commented Jun 7, 2023

@martint any chance we can get this merged? :P

@ryan0x44 ryan0x44 force-pushed the secret-only-if-passwordauth-set branch from a53a626 to e37f9c7 Compare November 23, 2023 03:50
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning and implementation look good to me.

Unrelated to this PR specifically I think we really need to build up more documentation resources for the chart. I will start on that in terms of descriptions for all the values soon.

@mosabua mosabua merged commit 7beaf33 into trinodb:main Nov 23, 2023
6 checks passed
@ryan0x44 ryan0x44 deleted the secret-only-if-passwordauth-set branch December 28, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants