Add proper tests for Spark images #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Nov 1, 2022
|
|
||
| set -x | ||
| set +e | ||
| sleep 10 |
There was a problem hiding this comment.
Why is sleep necessary? Add a comment? Also what about +e? Do we want to restore it after the test?
There was a problem hiding this comment.
Sleep is probably not needed - I just copied surrounding code.
set -e is done outside loop in single place.
There was a problem hiding this comment.
What about other iterations in the loop?
There was a problem hiding this comment.
It's set inside loop but after all branches. Sorry I said "outside loop".
alexjo2144
reviewed
Nov 1, 2022
ebyhr
approved these changes
Nov 1, 2022
This makes the image healthchecks redundant which were not much useful anyway since the port-liveness check is already done by testcontainers and some tests may want to not run the Thrift Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was useful for me to make sure if it's the Spark image being broken itself or some runtime issue when debugging issues in trinodb/trino#14810