Improve contribution process #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
commented
Sep 22, 2022
hashhar
force-pushed
the
hashhar/development
branch
from
4a96be6
to
49e5a03
Compare
hashhar
force-pushed
the
hashhar/development
branch
from
27a70be
to
3aa7b98
Compare
hovaesco
reviewed
Sep 23, 2022
| $ tox | ||
| ``` | ||
|
|
||
| When the code is ready, submit a Pull Request. |
There was a problem hiding this comment.
Perhaps indicating somewhere that creating an issue before actually starting working on something make sense to avoid unnecessary work which won't be accepted by maintainers?
There was a problem hiding this comment.
One of the first things linked from this DEVELOPMENT.md page - https://trino.io/development/process.html
Most of the information on Trino's DEVELOPMENT.md doesn't apply to Python and leads to confusion.
hashhar
force-pushed
the
hashhar/development
branch
from
3aa7b98
to
1b12fd6
Compare
ebyhr
approved these changes
Oct 2, 2022
hovaesco
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding DEVELOPMENT.md and CONTRIBUTING.md
Non-technical explanation
Clarify process of contributing to the project.
Release notes
(x) This is not user-visible or docs only and no release notes are required.