Fix updating PR comments from tests with secrets workflow

Don't use `always()` in step condition with additional predicates, because it ignores other predicates.
trinodb · Jul 14, 2023 · 219eea6 · 219eea6
1 parent ed65100
commit 219eea6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/actions/update-check/action.yml b/.github/actions/update-check/action.yml
@@ -25,7 +25,7 @@ runs:
   steps:
     - uses: actions/github-script@v6
       id: update-check-run
-      if: always() && inputs.check_name != '' && inputs.conclusion != ''
+      if: inputs.check_name != '' && inputs.conclusion != ''
       env:
         number: ${{ inputs.pull_request_number }}
         check_name: ${{ inputs.check_name }}

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -533,7 +533,6 @@ jobs:
       - name: Update PR check
         uses: ./.github/actions/update-check
         if: >-
-          always() &&
           github.event_name == 'repository_dispatch' &&
           github.event.client_payload.slash_command.args.named.sha != '' &&
           github.event.client_payload.pull_request.head.sha == github.event.client_payload.slash_command.args.named.sha