Remove stream usage from getPhysicalWrittenDataSize

trinodb · Aug 30, 2022 · 31e1b1a · 31e1b1a
1 parent 95fd190
commit 31e1b1a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/operator/DriverContext.java b/core/trino-main/src/main/java/io/trino/operator/DriverContext.java
@@ -275,9 +275,12 @@ public CounterStat getOutputPositions()
 
     public long getPhysicalWrittenDataSize()
     {
-        return operatorContexts.stream()
-                .mapToLong(OperatorContext::getPhysicalWrittenDataSize)
-                .sum();
+        // Avoid using stream api due to performance reasons
+        long physicalWrittenBytes = 0;
+        for (OperatorContext context : operatorContexts) {
+            physicalWrittenBytes += context.getPhysicalWrittenDataSize();
+        }
+        return physicalWrittenBytes;
     }
 
     public boolean isExecutionStarted()

diff --git a/core/trino-main/src/main/java/io/trino/operator/PipelineContext.java b/core/trino-main/src/main/java/io/trino/operator/PipelineContext.java
@@ -319,9 +319,12 @@ public CounterStat getOutputPositions()
 
     public long getPhysicalWrittenDataSize()
     {
-        return drivers.stream()
-                .mapToLong(DriverContext::getPhysicalWrittenDataSize)
-                .sum();
+        // Avoid using stream api due to performance reasons
+        long physicalWrittenBytes = 0;
+        for (DriverContext context : drivers) {
+            physicalWrittenBytes += context.getPhysicalWrittenDataSize();
+        }
+        return physicalWrittenBytes;
     }
 
     public PipelineStatus getPipelineStatus()