Remove kudu.client.default-socket-read-timeout config

Does not do anything in kudu 1.15.0
trinodb · Feb 16, 2022 · 42c0f56 · 42c0f56
1 parent 103dbcf
commit 42c0f56
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/docs/src/main/sphinx/connector/kudu.rst b/docs/src/main/sphinx/connector/kudu.rst
@@ -51,9 +51,6 @@ replacing the properties as appropriate:
    ## Default timeout used for user operations
    #kudu.client.default-operation-timeout = 30s
 
-   ## Default timeout to use when waiting on data from a socket
-   #kudu.client.default-socket-read-timeout = 10s
-
    ## Disable Kudu client's collection of statistics.
    #kudu.client.disable-statistics = false
 

diff --git a/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientConfig.java b/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientConfig.java
@@ -17,6 +17,7 @@
 import com.google.common.collect.ImmutableList;
 import io.airlift.configuration.Config;
 import io.airlift.configuration.ConfigDescription;
+import io.airlift.configuration.DefunctConfig;
 import io.airlift.units.Duration;
 import io.airlift.units.MaxDuration;
 import io.airlift.units.MinDuration;
@@ -32,14 +33,14 @@
 /**
  * Configuration read from etc/catalog/kudu.properties
  */
+@DefunctConfig("kudu.client.default-socket-read-timeout")
 public class KuduClientConfig
 {
     private static final Splitter SPLITTER = Splitter.on(',').trimResults().omitEmptyStrings();
 
     private List<String> masterAddresses;
     private Duration defaultAdminOperationTimeout = new Duration(30, TimeUnit.SECONDS);
     private Duration defaultOperationTimeout = new Duration(30, TimeUnit.SECONDS);
-    private Duration defaultSocketReadTimeout = new Duration(10, TimeUnit.SECONDS);
     private boolean disableStatistics;
     private boolean schemaEmulationEnabled;
     private String schemaEmulationPrefix = "presto::";
@@ -94,20 +95,6 @@ public Duration getDefaultOperationTimeout()
         return defaultOperationTimeout;
     }
 
-    @Config("kudu.client.default-socket-read-timeout")
-    public KuduClientConfig setDefaultSocketReadTimeout(Duration timeout)
-    {
-        this.defaultSocketReadTimeout = timeout;
-        return this;
-    }
-
-    @MinDuration("1s")
-    @MaxDuration("1h")
-    public Duration getDefaultSocketReadTimeout()
-    {
-        return defaultSocketReadTimeout;
-    }
-
     public boolean isDisableStatistics()
     {
         return this.disableStatistics;

diff --git a/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduModule.java b/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduModule.java
@@ -91,7 +91,6 @@ KuduClientSession createKuduClientSession(KuduClientConfig config)
         KuduClient.KuduClientBuilder builder = new KuduClient.KuduClientBuilder(config.getMasterAddresses());
         builder.defaultAdminOperationTimeoutMs(config.getDefaultAdminOperationTimeout().toMillis());
         builder.defaultOperationTimeoutMs(config.getDefaultOperationTimeout().toMillis());
-        builder.defaultSocketReadTimeoutMs(config.getDefaultSocketReadTimeout().toMillis());
         if (config.isDisableStatistics()) {
             builder.disableStatistics();
         }