Skip to content

Commit

Permalink
Avoid boxing in retained bytes per part consumer
Browse files Browse the repository at this point in the history
  • Loading branch information
pettyjamesm authored and sopel39 committed Mar 14, 2022
1 parent 7b3bed7 commit 5dd5d4d
Show file tree
Hide file tree
Showing 31 changed files with 62 additions and 62 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

import java.util.List;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static com.google.common.base.MoreObjects.toStringHelper;
import static io.trino.spi.type.BigintType.BIGINT;
Expand Down Expand Up @@ -203,7 +203,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(block, block.getRetainedSizeInBytes());
consumer.accept(this, (long) INSTANCE_SIZE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import javax.annotation.Nullable;

import java.util.Optional;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static java.lang.String.format;
Expand Down Expand Up @@ -145,7 +145,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, values.getRetainedSizeInBytes());
consumer.accept(offsets, sizeOf(offsets));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import javax.annotation.Nullable;

import java.util.Arrays;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.ArrayBlock.createArrayBlockInternal;
Expand Down Expand Up @@ -107,7 +107,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, values.getRetainedSizeInBytes());
consumer.accept(offsets, sizeOf(offsets));
Expand Down
4 changes: 2 additions & 2 deletions core/trino-spi/src/main/java/io/trino/spi/block/Block.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import java.util.Collections;
import java.util.List;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.trino.spi.block.BlockUtil.checkArrayRange;
import static io.trino.spi.block.DictionaryId.randomDictionaryId;
Expand Down Expand Up @@ -227,7 +227,7 @@ default long getLogicalSizeInBytes()
* {@code consumer} should be called at least once with the current block and
* must include the instance size of the current block
*/
void retainedBytesForEachPart(BiConsumer<Object, Long> consumer);
void retainedBytesForEachPart(ObjLongConsumer<Object> consumer);

/**
* Get the encoding for this block.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -108,7 +108,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
if (valueIsNull != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.calculateBlockResetSize;
Expand Down Expand Up @@ -174,7 +174,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
consumer.accept(valueIsNull, sizeOf(valueIsNull));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import java.util.Arrays;
import java.util.List;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -373,7 +373,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(dictionary, dictionary.getRetainedSizeInBytes());
consumer.accept(ids, sizeOf(ids));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -109,7 +109,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
if (valueIsNull != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.SIZE_OF_LONG;
import static io.airlift.slice.SizeOf.sizeOf;
Expand Down Expand Up @@ -188,7 +188,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
consumer.accept(valueIsNull, sizeOf(valueIsNull));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -115,7 +115,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(high, sizeOf(high));
consumer.accept(low, sizeOf(low));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.SIZE_OF_LONG;
import static io.airlift.slice.SizeOf.sizeOf;
Expand Down Expand Up @@ -211,7 +211,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(high, sizeOf(high));
consumer.accept(low, sizeOf(low));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -108,7 +108,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
if (valueIsNull != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.calculateBlockResetSize;
Expand Down Expand Up @@ -174,7 +174,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
consumer.accept(valueIsNull, sizeOf(valueIsNull));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
import java.util.ArrayList;
import java.util.List;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.ObjLongConsumer;

import static io.trino.spi.block.BlockUtil.checkArrayRange;
import static io.trino.spi.block.BlockUtil.checkValidRegion;
Expand Down Expand Up @@ -207,7 +207,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
getBlock().retainedBytesForEachPart(consumer);
consumer.accept(this, (long) INSTANCE_SIZE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -109,7 +109,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
if (valueIsNull != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.calculateBlockResetSize;
Expand Down Expand Up @@ -175,7 +175,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
consumer.accept(valueIsNull, sizeOf(valueIsNull));
Expand Down
4 changes: 2 additions & 2 deletions core/trino-spi/src/main/java/io/trino/spi/block/MapBlock.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import javax.annotation.Nullable;

import java.util.Optional;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.MapHashTables.HASH_MULTIPLIER;
Expand Down Expand Up @@ -233,7 +233,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(keyBlock, keyBlock.getRetainedSizeInBytes());
consumer.accept(valueBlock, valueBlock.getRetainedSizeInBytes());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.Optional;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.calculateBlockResetSize;
Expand Down Expand Up @@ -156,7 +156,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(keyBlockBuilder, keyBlockBuilder.getRetainedSizeInBytes());
consumer.accept(valueBlockBuilder, valueBlockBuilder.getRetainedSizeInBytes());
Expand Down
4 changes: 2 additions & 2 deletions core/trino-spi/src/main/java/io/trino/spi/block/RowBlock.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import javax.annotation.Nullable;

import java.util.Optional;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.ensureBlocksAreLoaded;
Expand Down Expand Up @@ -207,7 +207,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
for (int i = 0; i < numFields; i++) {
consumer.accept(fieldBlocks[i], fieldBlocks[i].getRetainedSizeInBytes());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Arrays;
import java.util.List;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.calculateBlockResetSize;
Expand Down Expand Up @@ -141,7 +141,7 @@ public long getRetainedSizeInBytes()
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
for (int i = 0; i < numFields; i++) {
consumer.accept(fieldBlockBuilders[i], fieldBlockBuilders[i].getRetainedSizeInBytes());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

import java.util.List;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.trino.spi.block.BlockUtil.checkArrayRange;
import static io.trino.spi.block.BlockUtil.checkValidPosition;
Expand Down Expand Up @@ -117,7 +117,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(value, value.getRetainedSizeInBytes());
consumer.accept(this, (long) INSTANCE_SIZE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.Optional;
import java.util.OptionalInt;
import java.util.function.BiConsumer;
import java.util.function.ObjLongConsumer;

import static io.airlift.slice.SizeOf.sizeOf;
import static io.trino.spi.block.BlockUtil.checkArrayRange;
Expand Down Expand Up @@ -108,7 +108,7 @@ public long getEstimatedDataSizeForStats(int position)
}

@Override
public void retainedBytesForEachPart(BiConsumer<Object, Long> consumer)
public void retainedBytesForEachPart(ObjLongConsumer<Object> consumer)
{
consumer.accept(values, sizeOf(values));
if (valueIsNull != null) {
Expand Down
Loading

0 comments on commit 5dd5d4d

Please sign in to comment.