Merge getViews and getTables GlueApiStats

trinodb · Feb 22, 2022 · 6293d52 · 6293d52
1 parent 1f7a537
commit 6293d52
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
@@ -493,7 +493,7 @@ public List<String> getAllViews(String databaseName)
                             .withDatabaseName(databaseName),
                     GetTablesRequest::setNextToken,
                     GetTablesResult::getNextToken,
-                    stats.getGetAllViews())
+                    stats.getGetTables())
                     .map(GetTablesResult::getTableList)
                     .flatMap(List::stream)
                     .filter(table -> VIRTUAL_VIEW.name().equals(table.getTableType()))
@@ -921,10 +921,10 @@ private List<Partition> batchGetPartition(Table table, List<String> partitionNam
                 for (List<PartitionValueList> partitions : Lists.partition(pendingPartitions, BATCH_GET_PARTITION_MAX_PAGE_SIZE)) {
                     long startTimestamp = System.currentTimeMillis();
                     batchGetPartitionFutures.add(glueClient.batchGetPartitionAsync(new BatchGetPartitionRequest()
-                            .withCatalogId(catalogId)
-                            .withDatabaseName(table.getDatabaseName())
-                            .withTableName(table.getTableName())
-                            .withPartitionsToGet(partitions),
+                                    .withCatalogId(catalogId)
+                                    .withDatabaseName(table.getDatabaseName())
+                                    .withTableName(table.getTableName())
+                                    .withPartitionsToGet(partitions),
                             new StatsRecordingAsyncHandler(stats.getGetPartitions(), startTimestamp)));
                 }
                 pendingPartitions.clear();

diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreStats.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreStats.java
@@ -31,7 +31,6 @@ public class GlueMetastoreStats
     private final GlueMetastoreApiStats getDatabase = new GlueMetastoreApiStats();
     private final GlueMetastoreApiStats getTables = new GlueMetastoreApiStats();
     private final GlueMetastoreApiStats getTable = new GlueMetastoreApiStats();
-    private final GlueMetastoreApiStats getAllViews = new GlueMetastoreApiStats();
     private final GlueMetastoreApiStats createDatabase = new GlueMetastoreApiStats();
     private final GlueMetastoreApiStats deleteDatabase = new GlueMetastoreApiStats();
     private final GlueMetastoreApiStats updateDatabase = new GlueMetastoreApiStats();
@@ -93,13 +92,6 @@ public GlueMetastoreApiStats getGetTable()
         return getTable;
     }
 
-    @Managed
-    @Nested
-    public GlueMetastoreApiStats getGetAllViews()
-    {
-        return getAllViews;
-    }
-
     @Managed
     @Nested
     public GlueMetastoreApiStats getCreateDatabase()