Skip to content

Commit

Permalink
Improve rendering of table
Browse files Browse the repository at this point in the history
- better column width adjustment
- easier source formatting as side benefit
  • Loading branch information
mosabua committed Apr 24, 2023
1 parent b3182d8 commit 6631a30
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 26 deletions.
2 changes: 1 addition & 1 deletion docs/src/main/sphinx/admin/graceful-shutdown.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Keep the following aspects in mind:
CA signed, or trusted by the server calling the shut down endpoint.
Otherwise, you can make the call ``--insecure``, but that isn't recommended.
* The ``default`` :doc:`/security/built-in-system-access-control` does not allow
graceful shutdowns. You can use the ``allow-all`` system access control, or
graceful shutdowns. You can use the ``allow-all`` system access control, or
configure :ref:`system information rules
<system-file-auth-system_information>` with the ``file`` system access
control. These configuration must be present on all workers.
Expand Down
8 changes: 4 additions & 4 deletions docs/src/main/sphinx/release/release-414.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@

## Security

* Disallow requesting [graceful shutdown](/admin/graceful-shutdown) with the
`default` [system access control](/security/built-in-system-access-control).
Shutdowns can be re-enabled by using the `allow-all` system access control, or
by configuring [system information rules](system-file-auth-system_information)
* Disallow [graceful shutdown](/admin/graceful-shutdown) with the `default`
[system access control](/security/built-in-system-access-control). Shutdowns
can be re-enabled by using the `allow-all` system access control, or by
configuring [system information rules](system-file-auth-system_information)
with the `file` system access control. ({issue}`17105`)

## Delta Lake connector
Expand Down
48 changes: 29 additions & 19 deletions docs/src/main/sphinx/security/built-in-system-access-control.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,47 @@ before any connector level authorization. You can use one of the built-in
implementations in Trino, or provide your own by following the guidelines in
:doc:`/develop/system-access-control`.

To use a system access control, add an ``etc/access-control.properties`` file
with the following content and the desired system access control name on all
cluster nodes:

.. code-block:: text
access-control.name=allow-all
Multiple system access control implementations may be configured at once
using the ``access-control.config-files`` configuration property. It should
contain a comma separated list of the access control property files to use
(rather than the default ``etc/access-control.properties``).

Trino offers the following built-in implementations:

================================================== =================================================================
System access control name Description
================================================== =================================================================
``default`` All operations are permitted, except for user impersonation and
triggering :doc:`/admin/graceful-shutdown`.

This is the default access control if none are configured.
Trino offers the following built-in system access control implementations:

``allow-all`` All operations are permitted.
.. list-table::
:widths: 20, 80
:header-rows: 1

``read-only`` Operations that read data or metadata are permitted, but
none of the operations that write data or metadata are allowed.
* - Name
- Description
* - ``default``
- All operations are permitted, except for user impersonation and triggering
:doc:`/admin/graceful-shutdown`.

``file`` Authorization rules are specified in a config file.
See :doc:`file-system-access-control`.
================================================== =================================================================
This is the default access control if none are configured.
* - ``allow-all``
- All operations are permitted.
* - ``read-only``
- Operations that read data or metadata are permitted, but none of the
operations that write data or metadata are allowed.
* - ``file``
- Authorization rules are specified in a config file. See
:doc:`file-system-access-control`.

If you want to limit access on a system level in any other way than the ones
listed above, you must implement a custom :doc:`/develop/system-access-control`.

Access control must be configured on the coordinator. However authorization for
certain operations, such a triggering :doc:`/admin/graceful-shutdown`, are
performed on specific worker nodes. In such cases access control must also be
configured on all workers.
Access control must be configured on the coordinator. Authorization for
operations on specific worker nodes, such a triggering
:doc:`/admin/graceful-shutdown`, must also be configured on all workers.

Read only system access control
===============================
Expand Down
4 changes: 2 additions & 2 deletions docs/src/main/sphinx/security/file-system-access-control.rst
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ interface. System information access includes the following aspects:
* Read access with the :doc:`/connector/system`.
* Write access to trigger :doc:`/admin/graceful-shutdown`.

The user is granted or denied access, based on the first matching
The user is granted or denied access based on the first matching
rule read from top to bottom. If no rules are specified, all access to system
information is denied. If no rule matches, system access is denied. Each rule is
composed of the following fields:
Expand All @@ -709,7 +709,7 @@ The following configuration provides and example:
.. literalinclude:: system-information-access.json
:language: json

* All users with the role ``admin`` have read and write access to system
* All users with the ``admin`` role have read and write access to system
information. This includes the ability to trigger
:doc:`/admin/graceful-shutdown`.
* The user ``alice`` can read system information.
Expand Down

0 comments on commit 6631a30

Please sign in to comment.