Skip to content

Commit

Permalink
Make SUPPORTS_RENAME_SCHEMA default to SUPPORTS_CREATE_SCHEMA
Browse files Browse the repository at this point in the history
If a connector doesn't support creating schemas it's not possible to
test if it supports renaming schemas. So to ensure test results aren't
misleading enforce that connectors that don't support schema creation
assume that schema rename isn't supported. The assumption is explicitly
validated so where needed it can be overridden by the connector.
  • Loading branch information
hashhar committed Jan 13, 2022
1 parent 85c230a commit 6fbdfa5
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ public enum TestingConnectorBehavior
SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_EQUALITY(fallback -> fallback.test(SUPPORTS_JOIN_PUSHDOWN) && fallback.test(SUPPORTS_PREDICATE_PUSHDOWN_WITH_VARCHAR_EQUALITY)),
SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_INEQUALITY(fallback -> fallback.test(SUPPORTS_JOIN_PUSHDOWN) && fallback.test(SUPPORTS_PREDICATE_PUSHDOWN_WITH_VARCHAR_INEQUALITY)),
SUPPORTS_CREATE_SCHEMA,
SUPPORTS_RENAME_SCHEMA,
// Expect rename to be supported when create schema is supported, to help make connector implementations coherent.
SUPPORTS_RENAME_SCHEMA(SUPPORTS_CREATE_SCHEMA),

SUPPORTS_CREATE_TABLE,
SUPPORTS_CREATE_TABLE_WITH_DATA(SUPPORTS_CREATE_TABLE),
Expand Down

0 comments on commit 6fbdfa5

Please sign in to comment.