Avoid writing to Hive an empty list of column stats because Hive 2.x …

…fails
trinodb · Aug 9, 2022 · 760615f · 760615f
1 parent 5c1da02
commit 760615f
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java b/...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
@@ -689,7 +689,9 @@ private void setColumnStatistics(String objectName, List<ColumnStatisticsObj> st
         verify(!dateStatistics.isEmpty() && metastoreSupportsDateStatistics.equals(Optional.empty()));
 
         try (ThriftMetastoreClient client = createMetastoreClient()) {
-            saveColumnStatistics.call(client, statisticsExceptDate);
+            if (!statisticsExceptDate.isEmpty()) {
+                saveColumnStatistics.call(client, statisticsExceptDate);
+            }
 
             try {
                 saveColumnStatistics.call(client, dateStatistics);

diff --git a/...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveTableStatistics.java b/...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveTableStatistics.java
@@ -1467,6 +1467,30 @@ public Object[][] testComputeFloatingPointStatisticsDataProvider()
         };
     }
 
+    @Test
+    public void testComputeStatisticsForTableWithOnlyDateColumns()
+    {
+        String tableName = "test_compute_statistics_with_only_date_columns";
+        onTrino().executeQuery("DROP TABLE IF EXISTS " + tableName);
+        try {
+            onTrino().executeQuery(format("CREATE TABLE %s AS SELECT date'2019-12-02' c_date", tableName));
+
+            List<Row> expectedStatistics = ImmutableList.of(
+                    isHiveVersionBefore12()
+                            ? row("c_date", null, null, null, null, null, null)
+                            : row("c_date", null, 1.0, 0.0, null, "2019-12-02", "2019-12-02"),
+                    row(null, null, null, null, 1.0, null, null));
+
+            assertThat(onTrino().executeQuery("SHOW STATS FOR " + tableName)).containsOnly(expectedStatistics);
+
+            onTrino().executeQuery("ANALYZE " + tableName);
+            assertThat(onTrino().executeQuery("SHOW STATS FOR " + tableName)).containsOnly(expectedStatistics);
+        }
+        finally {
+            onTrino().executeQuery("DROP TABLE IF EXISTS " + tableName);
+        }
+    }
+
     @Test
     @Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
     public void testMixedHiveAndPrestoStatistics()