Check other timezone

client/trino-jdbc/src/test/java/io/trino/jdbc/BaseTestJdbcResultSet.java

@@ -465,12 +465,12 @@ public void testTimeWithTimeZone()
                         Time.valueOf(
                                 LocalTime.of(15, 39, 7)).getTime() /* 15:39:07 = 00:39:07 - +01:00 shift + Bahia_Banderas's shift (-8) (modulo 24h which we "un-modulo" below) */
                                 - DAYS.toMillis(1) /* because we use currently 'shifted' representation, not possible to create just using LocalTime */
-                                + HOURS.toMillis(1) /* because there was offset shift on 1970-01-01 in America/Bahia_Banderas */);
+                                + HOURS.toMillis(1) /* because there was offset shift on 1970-01-01 in Mexico/BajaSur */);
                 assertThat(rs.getObject(column)).isEqualTo(someBogusValue); // TODO this should represent TIME '00:39:07 +01:00'
                 assertThatThrownBy(() -> rs.getDate(column))
                         .isInstanceOf(SQLException.class)
                         .hasMessage("Expected value to be a date but is: 00:39:07+01:00");
-                assertThat(rs.getTime(column)).isEqualTo(someBogusValue); // TODO this should fail, as there no java.sql.Time representation for TIME '00:39:07' in America/Bahia_Banderas
+                assertThat(rs.getTime(column)).isEqualTo(someBogusValue); // TODO this should fail, as there no java.sql.Time representation for TIME '00:39:07' in Mexico/BajaSur
                 assertThatThrownBy(() -> rs.getTimestamp(column))
                         .isInstanceOf(IllegalArgumentException.class) // TODO (https://github.com/trinodb/trino/issues/5315) SQLException
                         .hasMessage("Expected column to be a timestamp type but is time(0) with time zone");
@@ -684,7 +684,7 @@ public void testTimestampWithTimeZone()
                         assertThat(rs.getObject(column, ZonedDateTime.class)).isEqualTo(zonedDateTime);
                         assertThatThrownBy(() -> rs.getDate(column))
                                 .isInstanceOf(SQLException.class)
-                                .hasMessage("Expected value to be a date but is: 2019-12-31 23:59:59.999999999999 America/Bahia_Banderas");
+                                .hasMessage("Expected value to be a date but is: 2019-12-31 23:59:59.999999999999 Mexico/BajaSur");
                         assertThatThrownBy(() -> rs.getTime(column))
                                 .isInstanceOf(IllegalArgumentException.class) // TODO (https://github.com/trinodb/trino/issues/5315) SQLException
                                 .hasMessage("Expected column to be a time type but is timestamp(12) with time zone");

core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java

@@ -92,7 +92,7 @@ public void testCurrentDate()
     public void testCurrentDateTimezone()
     {
         TimeZoneKey kievTimeZoneKey = getTimeZoneKey("Europe/Kiev");
-        TimeZoneKey bahiaBanderasTimeZoneKey = getTimeZoneKey("America/Bahia_Banderas"); // The zone has 'gap' on 1970-01-01
+        TimeZoneKey bajaSurTimeZoneKey = getTimeZoneKey("Mexico/BajaSur"); // The zone has 'gap' on 1970-01-01
         TimeZoneKey montrealTimeZoneKey = getTimeZoneKey("America/Montreal");
         long timeIncrement = TimeUnit.MINUTES.toMillis(53);
         // We expect UTC millis later on so we have to use UTC chronology
@@ -101,7 +101,7 @@ public void testCurrentDateTimezone()
                 millis += timeIncrement) {
             Instant instant = Instant.ofEpochMilli(millis);
             assertCurrentDateAtInstant(kievTimeZoneKey, instant);
-            assertCurrentDateAtInstant(bahiaBanderasTimeZoneKey, instant);
+            assertCurrentDateAtInstant(bajaSurTimeZoneKey, instant);
             assertCurrentDateAtInstant(montrealTimeZoneKey, instant);
             assertCurrentDateAtInstant(TestingSession.DEFAULT_TIME_ZONE_KEY, instant);
         }
@@ -397,7 +397,7 @@ public void testLastDayOfMonth()
         assertThat(assertions.function("last_day_of_month", "TIMESTAMP '2001-08-22 03:04:05.321 +07:09'"))
                 .matches("DATE '2001-08-31'");
 
-        ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "America/Bahia_Banderas").forEach(timeZone -> {
+        ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "Mexico/BajaSur").forEach(timeZone -> {
             assertThat(assertions.function("last_day_of_month", "TIMESTAMP '2018-12-31 17:00:00.000 " + timeZone + "'"))
                     .matches("DATE '2018-12-31'");
 

core/trino-main/src/test/java/io/trino/tests/TestVerifyTrinoMainTestSetup.java

@@ -25,6 +25,6 @@ public class TestVerifyTrinoMainTestSetup
     public void testJvmZone()
     {
         // Ensure that the zone defined in the POM is correctly set in the test JVM
-        assertThat(ZoneId.systemDefault().getId()).isEqualTo("America/Bahia_Banderas");
+        assertThat(ZoneId.systemDefault().getId()).isEqualTo("Mexico/BajaSur");
     }
 }

lib/trino-hive-formats/src/test/java/io/trino/hive/formats/rcfile/RcFileTester.java

@@ -115,7 +115,7 @@
 
 public class RcFileTester
 {
-    public static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("America/Bahia_Banderas");
+    public static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("Mexico/BajaSur");
 
     static {
         HadoopNative.requireHadoopNative();

lib/trino-orc/src/test/java/io/trino/orc/OrcTester.java

@@ -207,7 +207,7 @@ public class OrcTester
             .withMaxBufferSize(DataSize.of(1, MEGABYTE))
             .withStreamBufferSize(DataSize.of(1, MEGABYTE))
             .withTinyStripeThreshold(DataSize.of(1, MEGABYTE));
-    public static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("America/Bahia_Banderas");
+    public static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("Mexico/BajaSur");
 
     public enum Format
     {

plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraTypeMapping.java

@@ -103,7 +103,7 @@ public class TestCassandraTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
         checkIsGap(jvmZone, timeGapInJvmZone1);

plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java

@@ -78,7 +78,7 @@ public abstract class BaseClickHouseTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
 

plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java

@@ -622,7 +622,7 @@ public void testTimestampPredicatePushdown()
     {
         testTimestampPredicatePushdown("1965-10-31 01:00:08.123 UTC");
         testTimestampPredicatePushdown("1965-10-31 01:00:08.999 UTC");
-        testTimestampPredicatePushdown("1970-01-01 01:13:42.000 America/Bahia_Banderas"); // There is a gap in JVM zone
+        testTimestampPredicatePushdown("1970-01-01 01:13:42.000 Mexico/BajaSur"); // There is a gap in JVM zone
         testTimestampPredicatePushdown("1970-01-01 00:00:00.000 Asia/Kathmandu");
         testTimestampPredicatePushdown("2018-10-28 01:33:17.456 Europe/Vilnius");
         testTimestampPredicatePushdown("9999-12-31 23:59:59.999 UTC");

plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeReadTimestamps.java

@@ -55,7 +55,7 @@ public class TestDeltaLakeReadTimestamps
     private static final Logger log = Logger.get(TestDeltaLakeReadTimestamps.class);
 
     private static final ZoneId UTC = ZoneId.of("UTC");
-    private static final ZoneId TEST_TIME_ZONE = ZoneId.of("America/Bahia_Banderas");
+    private static final ZoneId TEST_TIME_ZONE = ZoneId.of("Mexico/BajaSur");
     private static final DateTimeFormatter EXPECTED_VALUES_FORMATTER = new DateTimeFormatterBuilder()
             // This is equivalent to appendInstant(3) (yyyy-MM-ddTHH:mm:ss.SSS with 3-9 fractional digits),
             // but without a plus sign for years greater than 9999.

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

@@ -76,7 +76,7 @@ protected QueryRunner createQueryRunner()
     @BeforeAll
     void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         checkIsGap(jvmZone, timeGapInJvmZone1);
         checkIsGap(jvmZone, timeGapInJvmZone2);
         checkIsDoubled(jvmZone, timeDoubledInJvmZone);

plugin/trino-hive/src/test/java/io/trino/plugin/hive/HiveQueryRunner.java

@@ -74,7 +74,7 @@ private HiveQueryRunner() {}
     private static final String HIVE_BUCKETED_CATALOG = "hive_bucketed";
     public static final String TPCH_SCHEMA = "tpch";
     private static final String TPCH_BUCKETED_SCHEMA = "tpch_bucketed";
-    private static final DateTimeZone TIME_ZONE = DateTimeZone.forID("America/Bahia_Banderas");
+    private static final DateTimeZone TIME_ZONE = DateTimeZone.forID("Mexico/BajaSur");
 
     public static QueryRunner create()
             throws Exception

plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveFileFormats.java

@@ -221,7 +221,7 @@
 @Test(singleThreaded = true)
 public final class TestHiveFileFormats
 {
-    private static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("America/Bahia_Banderas");
+    private static final DateTimeZone HIVE_STORAGE_TIME_ZONE = DateTimeZone.forID("Mexico/BajaSur");
     private static final float EPSILON = 0.001f;
 
     private static final FileFormatDataSourceStats STATS = new FileFormatDataSourceStats();

plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java

@@ -133,7 +133,7 @@ public abstract class AbstractTestParquetReader
     protected AbstractTestParquetReader(ParquetTester tester)
     {
         this.tester = tester;
-        assertThat(DateTimeZone.getDefault()).isEqualTo(DateTimeZone.forID("America/Bahia_Banderas"));
+        assertThat(DateTimeZone.getDefault()).isEqualTo(DateTimeZone.forID("Mexico/BajaSur"));
 
         // Parquet has excessive logging at INFO level
         Logger.getLogger("org.apache.parquet.hadoop").setLevel(Level.WARNING);

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/procedure/TestIcebergMigrateProcedure.java

@@ -171,7 +171,7 @@ public void testMigrateTableWithComplexType(IcebergFileFormat fileFormat)
     @Test
     public void testMigrateTimestampHiveTableInComplexType()
     {
-        String inputValue = "2021-01-01 10:11:12.123"; // Tests are run with America/Bahia_Banderas timezone
+        String inputValue = "2021-01-01 10:11:12.123"; // Tests are run with Mexico/BajaSur timezone
         String expectedValue = "2021-01-01 16:11:12.123000 UTC";
 
         String tableName = "test_migrate_timestamp_complex_type_" + randomNameSuffix();

plugin/trino-ignite/src/test/java/io/trino/plugin/ignite/TestIgniteTypeMapping.java

@@ -72,7 +72,7 @@ protected QueryRunner createQueryRunner()
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         checkIsGap(jvmZone, LocalDate.of(1970, 1, 1));
         checkIsGap(vilnius, LocalDate.of(1983, 4, 1));
         verify(vilnius.getRules().getValidOffsets(LocalDate.of(1983, 10, 1).atStartOfDay().minusMinutes(1)).size() == 2);

plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduTypeMapping.java

@@ -67,7 +67,7 @@ final class TestKuduTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
         checkIsGap(jvmZone, timeGapInJvmZone1);

plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java

@@ -86,7 +86,7 @@ public class TestMariaDbTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         checkIsGap(jvmZone, LocalDate.of(1970, 1, 1));
         checkIsGap(vilnius, LocalDate.of(1983, 4, 1));
         verify(vilnius.getRules().getValidOffsets(LocalDate.of(1983, 10, 1).atStartOfDay().minusMinutes(1)).size() == 2);

plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java

@@ -92,7 +92,7 @@ public class TestMySqlTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         verify(jvmZone.getRules().getValidOffsets(dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay()).isEmpty());
 
@@ -1113,7 +1113,7 @@ public void testUnsupportedTimestampWithTimeZoneValues()
                     "Failed to insert data: Data truncation: Incorrect datetime value: '1969-12-31 16:00:00' for column 'data' at row 1");
             assertQueryFails(
                     "INSERT INTO " + table.getName() + " VALUES (TIMESTAMP '2038-01-19 03:14:08 UTC')", // max + 1
-                    "Failed to insert data: Data truncation: Incorrect datetime value: '2038-01-18 21:14:08' for column 'data' at row 1");
+                    "Failed to insert data: Data truncation: Incorrect datetime value: '2038-01-18 20:14:08' for column 'data' at row 1");
         }
     }
 

plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/AbstractTestOracleTypeMapping.java

@@ -103,7 +103,7 @@ public abstract class AbstractTestOracleTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
         checkIsGap(jvmZone, timeGapInJvmZone1);

plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixTypeMapping.java

@@ -90,7 +90,7 @@ public class TestPhoenixTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
 

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java

@@ -152,7 +152,7 @@ protected QueryRunner createQueryRunner()
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         checkIsGap(jvmZone, timeGapInJvmZone1);
         checkIsGap(jvmZone, timeGapInJvmZone2);
         checkIsDoubled(jvmZone, timeDoubledInJvmZone);

plugin/trino-singlestore/src/test/java/io/trino/plugin/singlestore/TestSingleStoreTypeMapping.java

@@ -106,7 +106,7 @@ protected QueryRunner createQueryRunner()
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
         LocalDateTime timeGapInJvmZone1 = LocalDateTime.of(1970, 1, 1, 0, 13, 42);

plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeTypeMapping.java

@@ -65,7 +65,7 @@ public class TestSnowflakeTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "Timezone not configured correctly. Add -Duser.timezone=America/Bahia_Banderas to your JVM arguments");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "Timezone not configured correctly. Add -Duser.timezone=America/Bahia_Banderas to your JVM arguments");
         checkIsGap(jvmZone, LocalDate.of(1970, 1, 1));
         checkIsGap(vilnius, LocalDate.of(1983, 4, 1));
         verify(vilnius.getRules().getValidOffsets(LocalDate.of(1983, 10, 1).atStartOfDay().minusMinutes(1)).size() == 2);

plugin/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerTypeMapping.java

@@ -87,7 +87,7 @@ public abstract class BaseSqlServerTypeMapping
     @BeforeAll
     public void setUp()
     {
-        checkState(jvmZone.getId().equals("America/Bahia_Banderas"), "This test assumes certain JVM time zone");
+        checkState(jvmZone.getId().equals("Mexico/BajaSur"), "This test assumes certain JVM time zone");
         LocalDate dateOfLocalTimeChangeForwardAtMidnightInJvmZone = LocalDate.of(1970, 1, 1);
         checkIsGap(jvmZone, dateOfLocalTimeChangeForwardAtMidnightInJvmZone.atStartOfDay());
         checkIsGap(jvmZone, timeGapInJvmZone1);

plugin/trino-tpcds/src/test/java/io/trino/plugin/tpcds/TestTpcds.java

@@ -104,7 +104,7 @@ public void testShowTables()
     @Test
     public void testDateColumnValuesCorrectness()
     {
-        // make sure date values are correct regardless of the system timezone selected (test are executed with the system timezone set to America/Bahia_Banderas)
+        // make sure date values are correct regardless of the system timezone selected (test are executed with the system timezone set to Mexico/BajaSur)
         assertQuery("SELECT d_date FROM date_dim WHERE d_date_id = 'AAAAAAAAOKJNECAA'", "SELECT DATE '1900-01-02'");
     }
 

pom.xml

@@ -157,14 +157,7 @@
         <air.javadoc.lint>syntax,reference,html,-missing</air.javadoc.lint>
         <air.modernizer.java-version>8</air.modernizer.java-version>
         <air.release.preparation-goals>clean verify -DskipTests</air.release.preparation-goals>
-        <!--
-          America/Bahia_Banderas has:
-           - offset change since 1970 (offset Jan 1970: -08:00, offset Jan 2018: -06:00)
-           - DST (e.g. at 2017-04-02 02:00:00 clocks turned forward 1 hour; 2017-10-29 02:00:00 clocks turned backward 1 hour)
-           - has forward offset change on first day of epoch (1970-01-01 00:00:00 clocks turned forward 1 hour)
-           - had forward change at midnight (1970-01-01 00:00:00 clocks turned forward 1 hour)
-          -->
-        <air.test.timezone>America/Bahia_Banderas</air.test.timezone>
+        <air.test.timezone>Mexico/BajaSur</air.test.timezone>
         <!-- Be conservative about memory allotment, because tests start background process (e.g. docker containers) -->
         <air.test.jvmsize>3g</air.test.jvmsize>
         <!-- G1 default region size for a small heap is 1MB. Tests (TestHiveConnectorTest.testMultipleWritersWhenTaskScaleWritersIsEnabled) in particular
@@ -200,7 +193,6 @@
         <dep.google.http.client.version>1.45.0</dep.google.http.client.version>
         <dep.iceberg.version>1.6.1</dep.iceberg.version>
         <dep.jna.version>5.15.0</dep.jna.version>
-        <dep.joda.version>2.12.7</dep.joda.version>
         <dep.jsonwebtoken.version>0.12.6</dep.jsonwebtoken.version>
         <dep.jts.version>1.20.0</dep.jts.version>
         <dep.kafka-clients.version>3.8.0</dep.kafka-clients.version>

testing/trino-tests/src/test/java/io/trino/tests/TestVerifyTrinoTestsTestSetup.java

@@ -26,7 +26,7 @@ public class TestVerifyTrinoTestsTestSetup
     public void testJvmZone()
     {
         // Ensure that the zone defined in the POM is correctly set in the test JVM
-        assertThat(ZoneId.systemDefault().getId()).isEqualTo("America/Bahia_Banderas");
+        assertThat(ZoneId.systemDefault().getId()).isEqualTo("Mexico/BajaSur");
     }
 
     @Test