Skip to content

Commit

Permalink
Fix invalid scope in trino-faker pom
Browse files Browse the repository at this point in the history
test-jar is not a valid value for <scope>. It's a valid value for <type>
however for trino-faker these dependencies' correct scope is runtime and
the type is jar.

Before this change the build logged a warning about this:

    Warning:  Some problems were encountered while building the effective model for io.trino:trino-faker:trino-plugin:466-SNAPSHOT
    Warning:  'dependencies.dependency.scope' for io.airlift:log:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 169, column 20
    Warning:  'dependencies.dependency.scope' for io.airlift:log-manager:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 175, column 20
    Warning:  'dependencies.dependency.scope' for io.trino:trino-client:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 181, column 20
    Warning:
    Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
    Warning:
    Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
  • Loading branch information
hashhar committed Nov 27, 2024
1 parent 82a242b commit 9004d0a
Showing 1 changed file with 18 additions and 18 deletions.
36 changes: 18 additions & 18 deletions plugin/trino-faker/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,30 @@
<scope>provided</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log-manager</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>units</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-client</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>junit-extensions</artifactId>
Expand Down Expand Up @@ -162,23 +180,5 @@
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
<scope>test-jar</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log-manager</artifactId>
<scope>test-jar</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-client</artifactId>
<scope>test-jar</scope>
</dependency>
</dependencies>
</project>

0 comments on commit 9004d0a

Please sign in to comment.