-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce Iceberg metrics reporting verbosity in logs
Iceberg's new feature, metrics reporting, by default logs quite long log lines at INFO level for every table scanned in the query. This is quite verbose, potentially affecting log rotation on production installations and affecting Trino CI Github Actions logs. Move the metrics reporting to DEBUG log level, at least for table instances instantiated directly in Trino code.
- Loading branch information
Showing
3 changed files
with
47 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoMetricsReporter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.trino.plugin.iceberg; | ||
|
||
import io.airlift.log.Logger; | ||
import org.apache.iceberg.metrics.LoggingMetricsReporter; | ||
import org.apache.iceberg.metrics.MetricsReport; | ||
import org.apache.iceberg.metrics.MetricsReporter; | ||
|
||
/** | ||
* Trino default {@link MetricsReporter} implementation. | ||
* <p> | ||
* Similar to Iceberg's default {@link MetricsReporter} implementation, | ||
* the {@link LoggingMetricsReporter}, but does not log at {@code INFO} level, | ||
* just eliminating log file size impact. | ||
* | ||
* @see LoggingMetricsReporter | ||
*/ | ||
public enum TrinoMetricsReporter | ||
implements MetricsReporter | ||
{ | ||
TRINO_METRICS_REPORTER; | ||
|
||
private static final Logger log = Logger.get(TrinoMetricsReporter.class); | ||
|
||
@Override | ||
public void report(MetricsReport report) | ||
{ | ||
log.debug("Received metrics report: %s", report); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters