Fix request partitions from Glue logic

In case requested partition are not found in Glue API can return empty partitions and empty unprocessed keys.
trinodb · Feb 15, 2024 · af2cd84 · af2cd84
1 parent eac7b9f
commit af2cd84
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
@@ -138,7 +138,6 @@
 
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Strings.isNullOrEmpty;
-import static com.google.common.base.Verify.verify;
 import static com.google.common.collect.Comparators.lexicographical;
 import static com.google.common.collect.ImmutableList.toImmutableList;
 import static com.google.common.collect.ImmutableMap.toImmutableMap;
@@ -1058,8 +1057,8 @@ private List<Partition> batchGetPartition(Table table, Collection<String> partit
                     List<PartitionValueList> unprocessedKeys = batchGetPartitionResult.getUnprocessedKeys();
 
                     // In the unlikely scenario where batchGetPartition call cannot make progress on retrieving partitions, avoid infinite loop
-                    if (partitions.isEmpty()) {
-                        verify(!unprocessedKeys.isEmpty(), "Empty unprocessedKeys for non-empty BatchGetPartitionRequest and empty partitions result");
+                    // We fail only in case there are still unprocessedKeys. Case with empty partitions and empty unprocessedKeys is correct in case partitions from request are not found.
+                    if (partitions.isEmpty() && !unprocessedKeys.isEmpty()) {
                         throw new TrinoException(HIVE_METASTORE_ERROR, "Cannot make progress retrieving partitions. Unable to retrieve partitions: " + unprocessedKeys);
                     }