Skip to content

Commit

Permalink
Make methods with default access private in PinotSegmentPageSource
Browse files Browse the repository at this point in the history
  • Loading branch information
elonazoulay authored and martint committed Jun 22, 2022
1 parent 6f286b4 commit db415a9
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -317,18 +317,18 @@ private void writeArrayBlock(BlockBuilder blockBuilder, Type columnType, int col
}
}

Type getType(int columnIndex)
private Type getType(int columnIndex)
{
checkArgument(columnIndex < columnHandles.size(), "Invalid field index");
return columnHandles.get(columnIndex).getDataType();
}

boolean getBoolean(int rowIdx, int columnIndex)
private boolean getBoolean(int rowIdx, int columnIndex)
{
return currentDataTable.getDataTable().getInt(rowIdx, columnIndex) != 0;
}

long getLong(int rowIndex, int columnIndex)
private long getLong(int rowIndex, int columnIndex)
{
DataSchema.ColumnDataType dataType = currentDataTable.getDataTable().getDataSchema().getColumnDataType(columnIndex);
// Note columnType in the dataTable could be different from the original columnType in the columnHandle.
Expand All @@ -348,7 +348,7 @@ long getLong(int rowIndex, int columnIndex)
}
}

double getDouble(int rowIndex, int columnIndex)
private double getDouble(int rowIndex, int columnIndex)
{
DataSchema.ColumnDataType dataType = currentDataTable.getDataTable().getDataSchema().getColumnDataType(columnIndex);
if (dataType.equals(ColumnDataType.FLOAT)) {
Expand All @@ -359,7 +359,7 @@ long getLong(int rowIndex, int columnIndex)
}
}

Block getArrayBlock(int rowIndex, int columnIndex)
private Block getArrayBlock(int rowIndex, int columnIndex)
{
Type trinoType = getType(columnIndex);
Type elementType = trinoType.getTypeParameters().get(0);
Expand Down Expand Up @@ -408,7 +408,7 @@ Block getArrayBlock(int rowIndex, int columnIndex)
return blockBuilder.build();
}

Slice getSlice(int rowIndex, int columnIndex)
private Slice getSlice(int rowIndex, int columnIndex)
{
Type trinoType = getType(columnIndex);
if (trinoType instanceof VarcharType) {
Expand All @@ -421,7 +421,7 @@ else if (trinoType instanceof VarbinaryType) {
return Slices.EMPTY_SLICE;
}

static byte[] toBytes(String stringValue)
private static byte[] toBytes(String stringValue)
{
try {
return Hex.decodeHex(stringValue.toCharArray());
Expand All @@ -431,7 +431,7 @@ static byte[] toBytes(String stringValue)
}
}

Slice getUtf8Slice(String value)
private Slice getUtf8Slice(String value)
{
if (isNullOrEmpty(value)) {
return Slices.EMPTY_SLICE;
Expand Down

0 comments on commit db415a9

Please sign in to comment.