Skip to content

Commit

Permalink
Exclude test from TestDeltaLakeDropTableCompatibility class
Browse files Browse the repository at this point in the history
Avoid running into a test failure when dealing with a
test depending on Databricks AWS S3 and AWS Glue environment.

Consult for further details:

#13017
  • Loading branch information
findinpath authored and ebyhr committed Jul 4, 2022
1 parent 3defb28 commit f89f14c
Showing 1 changed file with 13 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,25 @@ public static Object[][] engineConfigurations()
{TRINO, DELTA, true},
{TRINO, DELTA, false},
{DELTA, TRINO, true},
{DELTA, TRINO, false},
{DELTA, DELTA, true},
{DELTA, DELTA, false},
};
}

@Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}, dataProvider = "engineConfigurations")
public void testDatabricksManagedTableDroppedFromTrino(Engine creator, Engine dropper, boolean explicitLocation)
public void testDropTable(Engine creator, Engine dropper, boolean explicitLocation)
{
testDropTableAccuracy(creator, dropper, explicitLocation);
}

@Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS})
public void testCreateManagedTableInDeltaDropTableInTrino()
{
//TODO Integrate this method into `engineConfigurations()` data provider method after dealing with https://github.com/trinodb/trino/issues/13017
testDropTableAccuracy(DELTA, TRINO, false);
}

private void testDropTableAccuracy(Engine creator, Engine dropper, boolean explicitLocation)
{
String schemaName = "schema_with_location_" + randomTableSuffix();
String schemaLocation = format("s3://%s/databricks-compatibility-test-%s", bucketName, schemaName);
Expand Down

0 comments on commit f89f14c

Please sign in to comment.