Skip to content

Commit

Permalink
Fix ignored Future in TestDeltaLakePageSink
Browse files Browse the repository at this point in the history
It's to be future-proof and also suppress an error-prone warning.
Currently, the returned future is always already completed.
  • Loading branch information
findepi committed Aug 10, 2022
1 parent 4190e61 commit fdcbccd
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import java.util.Collection;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.TimeUnit;

import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.io.MoreFiles.deleteRecursively;
Expand Down Expand Up @@ -99,7 +100,7 @@ public void testPageSinkStats()
}
}
Page page = pageBuilder.build();
pageSink.appendPage(page);
pageSink.appendPage(page).get(10, TimeUnit.SECONDS);

JsonCodec<DataFileInfo> dataFileInfoCodec = new JsonCodecFactory().jsonCodec(DataFileInfo.class);
Collection<Slice> fragments = getFutureValue(pageSink.finish());
Expand Down

0 comments on commit fdcbccd

Please sign in to comment.