Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement COMMENT ON COLUMN in JDBC based connector #5333

Closed
6 of 9 tasks
ebyhr opened this issue Sep 29, 2020 · 8 comments
Closed
6 of 9 tasks

Implement COMMENT ON COLUMN in JDBC based connector #5333

ebyhr opened this issue Sep 29, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@agrawalreetika
Copy link
Member

@ebyhr, I would like to work on this. Could you please let me know if the issue is different from #5334?

@ebyhr
Copy link
Member Author

ebyhr commented Sep 29, 2020

@agrawalreetika While #5334 is for CREATE TABLE, this ticket's objective is supporting COMMENT ON COLUMN. I think this ticket is easier than #5334.

@shandeep00
Copy link
Contributor

@ebyhr @agrawalreetika anyone working on support for Mysql?

@agrawalreetika
Copy link
Member

@shandeep00 I have started looking into changes for implementing comment on a column in MySQL, will raise PR soon

@shandeep00
Copy link
Contributor

cool, maybe this can help u started, https://www.tutorialspoint.com/How-can-we-use-MySQL-ALTER-TABLE-command-for-adding-comments-on-columns

@Riddle4045
Copy link
Member

@ebyhr is the work for SQL server done? if not i'd be happy to take it!

@ebyhr
Copy link
Member Author

ebyhr commented Mar 21, 2022

@Riddle4045 Not yet. You can take it freely, but please note that:

  • SQL Server doesn't expose column comment via REMARKS result set. We will need to introduce a flag not to decrease the performance for metadata fetching.
  • You need to find how to create CREATE TABLE with column comments in SQL Server

@Riddle4045
Copy link
Member

Riddle4045 commented Mar 21, 2022

@ebyhr Thanks, I browsed through microsoft/mssql-jdbc#646, Looks like Microsoft does not intend to add support for REMARKS in the jdbc driver. This would mean we use extended properties for retrieving comments and multiple calls ( again through extended properties ) to support CREATE TABLE with column comments. I doubt that this feature should take up the estimated complexity budget for the connector, what do you think?

@ebyhr ebyhr closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

4 participants