Add COMMENT ON COLUMN support for Redshift Connector #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
9 tasks
ebyhr
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
Thanks for creating this PR. Could you send CLA if you haven't yet submitted it?
https://github.com/prestosql/cla
|
Submitted the CLA but probably will take sometime to get it merged. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #5333
Since there is no docker image available for Redshift, couldn't write any integration test for the change.
As Redshift is a variant of Postgres, it follows the same behaviour in this case.