-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ScyllaDB connector #10336
Add ScyllaDB connector #10336
Conversation
505e424
to
04317ba
Compare
bad8fe2
to
040e76c
Compare
cc @haaawk |
@robd003 Can you test this PR with your ScyllaDB cluster? |
Yes! Traveling today but will push the testEnvironment for Scylla and test this PR. |
db379aa
to
dded82f
Compare
0e4c015
to
66c373e
Compare
5b22745
to
dda5aaf
Compare
dda5aaf
to
76982e3
Compare
76982e3
to
c658433
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, mostly test changes and new tests.
<ignoredDependencies> | ||
<dependency> | ||
<groupId>com.datastax.oss</groupId> | ||
<artifactId>java-driver-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which dependency does it get duplicated by?
Please rebase. |
c658433
to
a13ee1c
Compare
a13ee1c
to
9579cd5
Compare
Is there any reason for keeping the following commits separate : ? |
@findinpath To keep clean diff. |
I get locally while trying to run:
the following exception:
|
e88a79e
to
c039442
Compare
c039442
to
7820f4c
Compare
This commit is preparation for the next commit.
Set minimum required version as 3.0.0 because ScyllaDB version 2.x can't detect partition correctly and it leads to query failure.
7820f4c
to
bf0365f
Compare
@robd003 Gentler reminder. |
I will reopen if necessary. |
@ebyhr Hey sir, just wondering why this wonderful PR was closed? what could i do to merge scylladb connector? |
I closed this PR as the requested contributor ghosted. I will reopen this PR if many people are interested in this connector. |
Hey! Anything that we can do to make this PR merged? I work at ScyllaDB, maybe we can help you guys in some way to make it happen. Cheers! |
Reopened the PR in #18074 |
Fixes #10276