Add function management abstractions #10378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
changed the title
dain
force-pushed
the
add-function-catalog
branch
from
0eeeed4 to
00c22e6
Compare
dain
force-pushed
the
add-function-catalog
branch
from
00c22e6 to
1c66331
Compare
dain
force-pushed
the
add-function-catalog
branch
from
1c66331 to
ba88058
Compare
dain
force-pushed
the
add-function-catalog
branch
2 times, most recently
from
67862c7 to
011bc82
Compare
martint
approved these changes
Mar 10, 2022
| @@ -228,13 +228,13 @@ public static BytecodeNode generateLambda( | |||
| return block; | |||
| } | |||
|
|
|||
| public static Class<? extends LambdaProvider> compileLambdaProvider(LambdaDefinitionExpression lambdaExpression, Metadata metadata, Class<?> lambdaInterface) | |||
| public static Class<? extends Supplier> compileLambdaProvider(LambdaDefinitionExpression lambdaExpression, Metadata metadata, Class<?> lambdaInterface) | |||
There was a problem hiding this comment.
Missing generics parameter for Supplier
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
Comment on lines
810
to
131
| public List<FunctionMetadata> listFunctions() | ||
| { | ||
| return functions.list(); | ||
| } | ||
|
|
||
| public Collection<FunctionMetadata> get(QualifiedName name) | ||
| public Collection<FunctionMetadata> getFunctions(QualifiedName name) | ||
| { | ||
| return functions.get(name); | ||
| } | ||
|
|
||
| public FunctionMetadata get(FunctionId functionId) | ||
| public FunctionMetadata getFunctionMetadata(FunctionId functionId) |
There was a problem hiding this comment.
Unrelated changes? Not sure the name changes buy much. It was quite obvious what the old names refer to when used in the context of the FunctionRegistry (now GlobalFunctionCatalog)
core/trino-main/src/main/java/io/trino/metadata/FunctionDependencies.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
add-function-catalog
branch
from
011bc82 to
0e5bcbb
Compare
|
The two test failures are are spurious/flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of internal APIs in preparation to move move the internal function APIs to the SPI package.
General information
Is this change a fix, improvement, new feature, refactoring, or other?
refactoring
Is this a change to the core query engine, a connector, client library, or the
SPI interfaces (be specific)?
core engine
How would you describe this change to a non-technical end user or system
administrator?
N/A
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: