Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve null statistics handling in product tests #10516

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Improve null statistics handling in product tests #10516

merged 2 commits into from
Jan 13, 2022

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 10, 2022 •
edited
Loading

Fixes #10366

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2022
@wendigo wendigo requested a review from findepi January 10, 2022 11:10
@wendigo
Improve null statistics handling in product tests
bad3c4d
@wendigo
Remove peak memory usage statistic
af206cd 
This statistics is not really useful and most of the time Docker engine returns null for it
@wendigo wendigo force-pushed the serafin/improve-null-handling-in-pt branch from fabb8f1 to af206cd Compare January 10, 2022 13:23
@wendigo
Copy link
Contributor Author

wendigo commented Jan 11, 2022

@findepi can we merge that?

@findepi
Copy link
Member

findepi commented Jan 11, 2022

it's red. What's the problem?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 11, 2022

Some unrelated flakyness of phoenix tests:

Caused by: org.apache.hbase.thirdparty.io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Cannot assign requested address

@findepi
Copy link
Member

findepi commented Jan 12, 2022

Do we have an issue for this?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 12, 2022

Do we have an issue for this?

I'll create one @findepi

@findepi findepi merged commit ab9962c into trinodb:master Jan 13, 2022
@findepi
Copy link
Member

findepi commented Jan 13, 2022

I'll create one

thanks!

@github-actions github-actions bot added this to the 369 milestone Jan 13, 2022
@mosabua mosabua mentioned this pull request Jan 13, 2022
Merged
@wendigo wendigo deleted the serafin/improve-null-handling-in-pt branch January 21, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
369
Development

Successfully merging this pull request may close these issues.

A NPE when starting product tests
2 participants
@wendigo @findepi