Negate method invocation #10728
Merged
Negate method invocation #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a dead code, but should be correct anyway
|
This looks like a correctness fix. Is it testable? |
|
The actual implementation that is used is bytecode-generated. This is not used anywhere, so no tests so far |
sopel39
approved these changes
Jan 24, 2022
sopel39
reviewed
Jan 24, 2022
| @@ -215,7 +215,7 @@ public boolean positionNotDistinctFromRow(int leftBlockIndex, int leftPosition, | |||
| Block leftBlock = channels.get(hashChannel).get(leftBlockIndex); | |||
| Block rightBlock = page.getBlock(rightChannels[i]); | |||
| BlockPositionIsDistinctFrom isDistinctFromOperator = isDistinctFromOperators.get(i); | |||
| if (!isDistinctFromOperator.isDistinctFrom(leftBlock, leftPosition, rightBlock, rightPosition)) { | |||
| if (isDistinctFromOperator.isDistinctFrom(leftBlock, leftPosition, rightBlock, rightPosition)) { | |||
There was a problem hiding this comment.
please add a test to io.trino.operator.TestSimplePagesHashStrategy
It's not dead code yet (although it should be)
// if compilation fails, use interpreter
return new SimplePagesHashStrategy(
I think we should remove that fallback
|
👋 @skrzypo987 and @sopel39 .. can this be merged? |
|
no release notes needed |
|
Sweet.. thank @sopel39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.