Validate the end of input when parsing JSON #10783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #10724 |
findepi
approved these changes
Jan 25, 2022
| assertFails("SELECT JSON '{}{abc'") | ||
| .hasErrorCode(INVALID_LITERAL); | ||
| assertFails("SELECT JSON '{}abc'") | ||
| .hasErrorCode(INVALID_LITERAL); |
There was a problem hiding this comment.
let's have tests with json_parse invocation too
kasiafi
force-pushed
the
307JsonParse
branch
2 times, most recently
from
eaa2d56 to
3ade9c2
Compare
Before this change, the end of input after reading a JSON value
was not properly validated:
- if there were remaining characters which did not parse as JSON,
exception was thrown. E.g. `'["correct JSON"]and more'` failed
- if there were remaining characters which formed a valid token,
they were silently ignored. E.g. `'["correct JSON"]{and more'`
succeeded and returned `'["correct JSON"]'`
After this change, any trailing characters are caught and reported
as error.
Praveen2112
approved these changes
Jan 27, 2022
findepi
approved these changes
Jan 27, 2022
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Feb 28, 2022
Cherry-pick of trinodb/trino#10783 Before this change, the end of input after reading a JSON value was not properly validated: - if there were remaining characters which did not parse as JSON, exception was thrown. E.g. `'["correct JSON"]and more'` failed - if there were remaining characters which formed a valid token, they were silently ignored. E.g. `'["correct JSON"]{and more'` succeeded and returned `'["correct JSON"]'` After this change, any trailing characters are caught and reported as error. Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10724