-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document hive storage table properties #10817
Conversation
This is wrong. The properties are NOT catalog properties .. they are table properties .. |
6b47b31
to
31eed1c
Compare
Pretty sure there are more table properties. Check in #8905 and maybe in the code and/or a running system |
I wonder if it makes sense to move the table properties and "runtime" properties in general to a different page. If I were to place these anywhere it might be below the static config file properties. That seems really out of the way though and buried. Just one thought, let's split config file props and runtime props on different pages. |
While that is a feasible approach and the Hive connector page is in dire need of refactor and such .. I dont want to take this work into the scope of this PR. We just want to document the table properties, explain what they are and a bit how to use them |
31eed1c
to
3ebc2b0
Compare
3ebc2b0
to
356041f
Compare
356041f
to
793dee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments.
@hashhar I reviewed this now and @rosewms will address various comments. However I have a question left ... in this PR we document table properties ... do we need another section for schema properties? Or are they the same? If they are the same then we should add that they are also honoured for |
Schema properties are separate. See https://trino.io/docs/current/sql/create-schema.html#description for how to find them. |
793dee7
to
ed305c4
Compare
ed305c4
to
4076810
Compare
4076810
to
8af411d
Compare
0963480
to
bbc246f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go % comments.
- The serialization format for ``NULL`` value. Requires TextFile, RCText, | ||
or SequenceFile format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for information - null_format
can be set to a string that is then interpreted as a marker for NULL
values in table files.
e.g. with null_format = 'NULL_VALUE_MARKER'
and a TextFile table with some line like a\u0001NULL_VALUE_MARKER\u0001null value
would get read as 3 columns a
, NULL
and null value
.
If we want to document this it should be a separate effort - not part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosabua how should I proceed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should create an issue to follow up IMO?
bbc246f
to
d69e2c1
Compare
Yay @rosewms! Thanks for finishing this! |
Issue: #5581