Let jdbc-based connectors control how data should be written and predicates pushed down #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
2 times, most recently
from
5e41192 to
815a02a
Compare
findepi
commented
Jan 30, 2019
| return ColumnMapping.longMapping(decimalType, | ||
| (resultSet, columnIndex) -> encodeShortScaledValue(resultSet.getBigDecimal(columnIndex), scale), | ||
| shortDecimalWriteFunction(decimalType)) | ||
| .withPredicatePushdownFilter(domain -> false); // TODO enable |
There was a problem hiding this comment.
Decimal predicate pushdown was not allowed in io.prestosql.plugin.jdbc.QueryBuilder#isAcceptedType and this is why it's retained as not allowed in this refactoring.
| decimalType, | ||
| (resultSet, columnIndex) -> encodeScaledValue(resultSet.getBigDecimal(columnIndex), scale), | ||
| longDecimalWriteFunction(decimalType)) | ||
| .withPredicatePushdownFilter(domain -> false); // TODO enable |
There was a problem hiding this comment.
Decimal predicate pushdown was not allowed in io.prestosql.plugin.jdbc.QueryBuilder#isAcceptedType and this is why it's retained as not allowed in this refactoring.
findepi
commented
Jan 30, 2019
| private final Type type; | ||
| private final ReadFunction readFunction; | ||
| private final WriteFunction writeFunction; | ||
| private final Predicate<Domain> predicatePushdownFilter; |
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
2 times, most recently
from
2e378c9 to
567c293
Compare
sopel39
reviewed
Feb 4, 2019
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BooleanWriteFunction.java
Show resolved
Hide resolved
sopel39
reviewed
Feb 4, 2019
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/WriteMapping.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
from
567c293 to
e7f702f
Compare
sopel39
reviewed
Feb 5, 2019
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/ColumnMapping.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
2 times, most recently
from
21880a1 to
b5f2789
Compare
sopel39
approved these changes
Feb 5, 2019
|
@sopel39 AC |
electrum
reviewed
Feb 8, 2019
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/StandardColumnMappings.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcPageSink.java
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/WriteMapping.java
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java
Outdated
Show resolved
Hide resolved
findepi
commented
Feb 8, 2019
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/StandardColumnMappings.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcPageSink.java
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/WriteMapping.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
from
b5f2789 to
3c9c460
Compare
WriteMapping captures how data should be written in a JDBC connector: - what data type should be used in the remote database - how the data should be bound to `PreparedStatement`
findepi
force-pushed
the
findepi/jdbc-column-mapping
branch
from
2620bff to
b5fa79a
Compare
rice668
pushed a commit
to rice668/trino
that referenced
this pull request
Jan 31, 2023
… branches with multiple repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, a jdbc-based connector controls how data should be read from a
ResultSetviaReadMappingdefinitions. However, writing is hard-coded inJdbcPageSink#appendColumn.This expands the
ReadMappingconcept intoColumnMappingwhich controls both reading and pushdown.This also introduces separate
WriteMappingconcept which is used for writing (currently both CTAS and INSERT)Ref prestodb/presto#12151