-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support for ALTER TABLE SET PROPERTIES #11022
Conversation
@@ -82,9 +98,19 @@ Allow everyone with role public to drop and alter table ``people``:: | |||
|
|||
ALTER TABLE people SET AUTHORIZATION ROLE PUBLIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interaction between pure SQL role granting and access control role granting is ... unexplored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, but ultimately out of scope for this PR. If someone has input then I can file a follow-up issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ordinant Do you mean using things like file-based access control together with SQL based access control?
If so such a configuration can never be possible since Trino only allows a single type of system access control to be available at a time.
However connectors may provide their own - and the rule there is that system level configuration wins over connector specific ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with quibbles. The ticket probably should be titled "Document lack of support for ..."
8ad8349
to
f443264
Compare
cc: @joshthoward for technical correctness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending comments
1e4bdf2
to
aaa91bd
Compare
756fbca
to
f29e556
Compare
Discussed with @electrum and agreed that it's probably too granular to devote a sub-section to connector pages that says |
f29e556
to
ef7583f
Compare
ef7583f
to
2cce907
Compare
@electrum Can we merge this? |
Description
ALTER TABLE SET PROPERTIES
has been supported for a while, but has been missing practical details such as detailed examples, use of the DEFAULT keyword, and what connectors (don't) support it.General information
Improvement
Documentation
Further document support and use of ALTER TABLE SET PROPERTIES
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: