Link to comparison operators page #11026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Feb 14, 2022
Jessie212
force-pushed
the
jt/like-pattern
branch
from
06376f5 to
f9cfe26
Compare
Jessie212
force-pushed
the
jt/like-pattern
branch
2 times, most recently
from
e368c0d to
949aa4e
Compare
hashhar
reviewed
Feb 17, 2022
mosabua
requested changes
Feb 18, 2022
Jessie212
force-pushed
the
jt/like-pattern
branch
from
949aa4e to
c955dcb
Compare
jhlodin
approved these changes
Feb 18, 2022
Jessie212
force-pushed
the
jt/like-pattern
branch
2 times, most recently
from
ddddfc5 to
e405740
Compare
hashhar
reviewed
Feb 28, 2022
Comment on lines
18
to
20
| filter the results to the desired subset. For example, the following query | ||
| allows you to find catalogs where the first character in a value is specified. | ||
| Query results show catalogs that begin with ``t``:: |
There was a problem hiding this comment.
Suggested change
| filter the results to the desired subset. For example, the following query | |
| allows you to find catalogs where the first character in a value is specified. | |
| Query results show catalogs that begin with ``t``:: | |
| filter the results to the desired subset. For example, the following query | |
| allows you to find catalogs whose names begin with ``t``:: |
Similar in other places too? Existing wording seems repetitive (first we describe what query does in very abstract terms and then follow with the concrete meaning).
There was a problem hiding this comment.
I like that .. want to adapt to that @Jessie212 ?
There was a problem hiding this comment.
Great suggestion, @hashhar. Applied.
Jessie212
force-pushed
the
jt/like-pattern
branch
from
e405740 to
6ee26a8
Compare
mosabua
requested changes
Mar 3, 2022
Jessie212
force-pushed
the
jt/like-pattern
branch
from
6ee26a8 to
46bd469
Compare
mosabua
reviewed
Mar 4, 2022
|
|
||
| SHOW SESSION LIKE 'query%' | ||
|
|
||
| See related syntax |
There was a problem hiding this comment.
Why the title change here? lets undo that ..
There was a problem hiding this comment.
I'll revert it because it isn't related to the task, but "See also" sounds weird. Plus, it's an incomplete action, imo. I think it should say something like, "See more session commands".
Jessie212
force-pushed
the
jt/like-pattern
branch
from
46bd469 to
c3ff7e0
Compare
electrum
approved these changes
Mar 4, 2022
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Mar 10, 2022
Cherry-pick of trinodb/trino#11026 Co-authored-by: Jessica <jessica.twitty-shuler@starburstdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General information
Improvement.
Documentation
Link to comparison operators page
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: