Add redirection awareness for ADD COLUMN, COMMENT, DROP table tasks #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
add-redirection-awareness-add-column-comment-drop-table
branch
from
324e709 to
1bef4af
Compare
phd3
suggested changes
Feb 18, 2022
core/trino-main/src/main/java/io/trino/execution/DropTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CommentTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/AddColumnTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/AddColumnTask.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
add-redirection-awareness-add-column-comment-drop-table
branch
from
28adcd6 to
39f330a
Compare
findinpath
commented
Feb 22, 2022
| QualifiedObjectName originalTableName = createQualifiedObjectName(session, statement, statement.getName()); | ||
| RedirectionAwareTableHandle redirectionAwareTableHandle = metadata.getRedirectionAwareTableHandle(session, originalTableName); | ||
| if (redirectionAwareTableHandle.getTableHandle().isEmpty()) { | ||
| throw semanticException(TABLE_NOT_FOUND, statement, "Table does not exist: %s", originalTableName); |
There was a problem hiding this comment.
Do we need to wrap the throw with a statement existence check?
if (!statement.isTableExists()) {
throw semanticException...
}
return immediateVoidFuture();
findinpath
commented
Feb 22, 2022
| QualifiedObjectName originalTableName = createQualifiedObjectName(session, statement, prefix.get()); | ||
| RedirectionAwareTableHandle redirectionAwareTableHandle = metadata.getRedirectionAwareTableHandle(session, originalTableName); | ||
| if (redirectionAwareTableHandle.getTableHandle().isEmpty()) { | ||
| throw semanticException(TABLE_NOT_FOUND, statement, "Table does not exist: " + originalTableName); |
There was a problem hiding this comment.
Reminder for statement existence check.
findinpath
force-pushed
the
add-redirection-awareness-add-column-comment-drop-table
branch
from
39f330a to
f62c8ec
Compare
|
Rebasing on |
findinpath
force-pushed
the
add-redirection-awareness-add-column-comment-drop-table
branch
from
f62c8ec to
5347c09
Compare
findepi
approved these changes
Feb 25, 2022
|
@phd3 do you want to take another look? |
phd3
reviewed
Feb 25, 2022
core/trino-main/src/main/java/io/trino/execution/DropTableTask.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
add-redirection-awareness-add-column-comment-drop-table
branch
from
5347c09 to
86ad52a
Compare
findinpath
changed the title
11 tasks
findepi
approved these changes
Feb 28, 2022
|
unrelated #11245 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add redirection awareness for the following tasks:
This is a fix.
This is a core engine change affecting mainly hive/iceberg connectors.
In the context of dealing with a shared Hive Metastore Service where tables of different types can co-exist in the metastore, it is helpful for the end-user to perform automatically table redirections when the user is in the context of a hive schema, but is referencing an iceberg table.
Related issues, pull requests, and links
This is a spin-off from the PR: #10577
Documentation
( x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( x) Release notes entries required with the following suggested text:
Relates to #11202