Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate collection builder with factory method #11118

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Instantiate collection builder with factory method #11118

merged 1 commit into from
Feb 25, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 21, 2022

The immutable collection classes provide Builder which can be
instantiated with constructor or static factory method. The latter is
preferred, and now also required.

@cla-bot cla-bot bot added the cla-signed label Feb 21, 2022
ksobolew
ksobolew approved these changes Feb 21, 2022
View reviewed changes
.mvn/modernizer/violations.xml Outdated Show resolved Hide resolved
@findepi findepi force-pushed the findepi/build-right branch from 63c5aee to a08d8eb Compare February 21, 2022 15:53
@losipiuk
Copy link
Member

CI:

2022-02-21T19:19:32.2484113Z [ERROR] Error occurred in starting fork, check output in log
2022-02-21T19:19:32.2486971Z [ERROR] Process Exit Code: 1
2022-02-21T19:19:32.2489520Z [ERROR] Crashed tests:
2022-02-21T19:19:32.2492528Z [ERROR] io.trino.plugin.hive.benchmark.TestHiveFileFormatBenchmark
2022-02-21T19:19:32.2495686Z [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:748)
2022-02-21T19:19:32.2499151Z [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:305)
2022-02-21T19:19:32.2502685Z [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:265)
2022-02-21T19:19:32.2506841Z [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1314)
2022-02-21T19:19:32.2511302Z [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1159)
2022-02-21T19:19:32.2515562Z [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:932)
2022-02-21T19:19:32.2519223Z [ERROR] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
2022-02-21T19:19:32.2524808Z [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
2022-02-21T19:19:32.2529147Z [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
2022-02-21T19:19:32.2533543Z [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
2022-02-21T19:19:32.2540778Z [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
2022-02-21T19:19:32.2541970Z [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
2022-02-21T19:19:32.2543291Z [ERROR] 	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
2022-02-21T19:19:32.2544302Z [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
2022-02-21T19:19:32.2544918Z [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
2022-02-21T19:19:32.2556662Z [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
2022-02-21T19:19:32.2557261Z [ERROR] 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
2022-02-21T19:19:32.2557777Z [ERROR] 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:972)
2022-02-21T19:19:32.2558276Z [ERROR] 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
2022-02-21T19:19:32.2558754Z [ERROR] 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
2022-02-21T19:19:32.2559343Z [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-02-21T19:19:32.2560310Z [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-02-21T19:19:32.2561115Z [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-02-21T19:19:32.2561719Z [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-02-21T19:19:32.2562348Z [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
2022-02-21T19:19:32.2566514Z [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
2022-02-21T19:19:32.2567403Z [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
2022-02-21T19:19:32.2568046Z [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
2022-02-21T19:19:32.2568851Z [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-02-21T19:19:32.2569574Z [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-02-21T19:19:32.2570341Z [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-02-21T19:19:32.2570927Z [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-02-21T19:19:32.2571509Z [ERROR] 	at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39)
2022-02-21T19:19:32.2572138Z [ERROR] 	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122)
2022-02-21T19:19:32.2572743Z [ERROR] 	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:61)
2022-02-21T19:19:32.2573224Z [ERROR] -> [Help 1]

@ksobolew
Copy link
Contributor

This one is more pertinent:

Error:  The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

This is worrying. It happened twice on one of my other PRs (in a completely different build job), then went away.

@ksobolew
Copy link
Contributor

There's also:

2022-02-21T19:27:46.2481099Z [ERROR] Failures: 
2022-02-21T19:27:46.2492145Z [ERROR]   TestHiveTaskFailureRecoveryTest>BaseHiveFailureRecoveryTest.testReplaceExistingPartition:141->BaseFailureRecoveryTest.testTableModification:364->BaseFailureRecoveryTest.testNonSelect:438 For query: 
2022-02-21T19:27:46.2493554Z  INSERT INTO <table> SELECT *, 'partition1' p FROM orders
2022-02-21T19:27:46.2494136Z not equal
2022-02-21T19:27:46.2494515Z Actual rows (up to 100 of 15000 extra rows shown, 30000 rows in total):

in test (:trino-hive -P test-failure-recovery). Could be a flake?

@kokosing
Copy link
Member 

2022-02-21T19:19:13.8656563Z java.lang.IllegalStateException: There already is a start record for test: io.trino.plugin.hive.TestHive3OnDataLake
2022-02-21T19:19:13.8657495Z 	at com.google.common.base.Preconditions.checkState(Preconditions.java:590)
2022-02-21T19:19:13.8658385Z 	at io.trino.testng.services.LogTestDurationListener.beginTest(LogTestDurationListener.java:245)
2022-02-21T19:19:13.8660335Z 	at io.trino.testng.services.LogTestDurationListener.onBeforeClass(LogTestDurationListener.java:179)
2022-02-21T19:19:13.8661250Z 	at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:167)
2022-02-21T19:19:13.8672381Z 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
2022-02-21T19:19:13.8672957Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2022-02-21T19:19:13.8673630Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2022-02-21T19:19:13.8674082Z 	at java.base/java.lang.Thread.run(Thread.java:829)

@findepi findepi force-pushed the findepi/build-right branch from a08d8eb to dd07005 Compare February 23, 2022 09:25
@findepi
Copy link
Member Author

findepi commented Feb 23, 2022

(rebased to resolve conflicts)

@findepi
Copy link
Member Author

findepi commented Feb 23, 2022 

ci / test (:trino-kudu) (pull_request) Failing after 6m — test (:trino-kudu)

@losipiuk
Copy link
Member

kudu failed again:

Error:  io.trino.plugin.kudu.KuduSmokeTests$TestKuduWithEmptyInferSchemaConnectorTest.init  Time elapsed: 55.43 s  <<< FAILURE!
java.lang.RuntimeException: Schema tpch not found
	at io.trino.testing.AbstractTestingTrinoClient.execute(AbstractTestingTrinoClient.java:122)
	at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:505)
	at io.trino.testing.QueryAssertions.copyTable(QueryAssertions.java:339)
	at io.trino.testing.QueryAssertions.copyTable(QueryAssertions.java:331)
	at io.trino.testing.QueryAssertions.copyTpchTables(QueryAssertions.java:323)
	at io.trino.plugin.kudu.KuduQueryRunnerFactory.createKuduQueryRunnerTpch(KuduQueryRunnerFactory.java:107)
	at io.trino.plugin.kudu.KuduQueryRunnerFactory.createKuduQueryRunnerTpch(KuduQueryRunnerFactory.java:83)
	at io.trino.plugin.kudu.AbstractKuduConnectorTest.createQueryRunner(AbstractKuduConnectorTest.java:54)
	at io.trino.testing.AbstractTestQueryFramework.init(AbstractTestQueryFramework.java:83)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:515)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:217)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:144)
	at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:169)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
	Suppressed: java.lang.Exception: SQL: CREATE TABLE IF NOT EXISTS customer AS SELECT * FROM tpch.tiny.customer
		at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:508)
		... 20 more
Caused by: io.trino.spi.connector.SchemaNotFoundException: Schema tpch not found
	at io.trino.plugin.kudu.KuduClientSession.openTable(KuduClientSession.java:238)
	at io.trino.plugin.kudu.KuduOutputTableHandle.getTable(KuduOutputTableHandle.java:91)
	at io.trino.plugin.kudu.KuduPageSink.<init>(KuduPageSink.java:89)
	at io.trino.plugin.kudu.KuduPageSinkProvider.createPageSink(KuduPageSinkProvider.java:46)
	at io.trino.split.PageSinkManager.createPageSink(PageSinkManager.java:54)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createPageSink(TableWriterOperator.java:126)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createOperator(TableWriterOperator.java:120)
	at io.trino.operator.DriverFactory.createDriver(DriverFactory.java:114)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunnerFactory.createDriver(SqlTaskExecution.java:958)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:1086)
	at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:163)
	at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:488)
	at io.trino.$gen.Trino_testversion____20220223_202105_145.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

@findepi
Copy link
Member Author

findepi commented Feb 24, 2022

The kudu test seems relatively recently changed (#10940, #11113), so there is some chance it's flake?
FWIW it passed locally, so let me re run the Ci

@findepi findepi force-pushed the findepi/build-right branch from 04b3740 to 0066f3b Compare February 25, 2022 11:05
@findepi
Copy link
Member Author

findepi commented Feb 25, 2022

(rebased on master to fix new offences; no fixes yet)

@findepi
Copy link
Member Author

findepi commented Feb 25, 2022

btw kudu tests were green in last run (https://github.com/trinodb/trino/runs/5319940309?check_suite_focus=true) before rebase

@findepi
Instantiate collection builder with factory method
d7373a3 
The immutable collection classes provide `Builder` which can be
instantiated with constructor or static factory method. The latter is
preferred, and now also required.
@findepi findepi force-pushed the findepi/build-right branch from 0066f3b to d7373a3 Compare February 25, 2022 11:43
@findepi findepi merged commit 03a4d53 into trinodb:master Feb 25, 2022
@findepi findepi deleted the findepi/build-right branch February 25, 2022 15:11
@mosabua mosabua mentioned this pull request Feb 25, 2022
Merged
@github-actions github-actions bot added this to the 372 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksobolew ksobolew ksobolew approved these changes

@kokosing kokosing kokosing approved these changes

@losipiuk losipiuk losipiuk approved these changes

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
cla-signed
Milestone
372
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @losipiuk @ksobolew @kokosing