Remove unnecessary purgeData parameter of TrinoCatalog.dropTable #11167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's always same (`true`), because Trino doesn't have two flavors of `DROP TABLE`.
findepi
requested review from
electrum,
losipiuk,
phd3,
alexjo2144 and
findinpath
findinpath
approved these changes
Feb 23, 2022
alexjo2144
approved these changes
Feb 23, 2022
phd3
approved these changes
Feb 24, 2022
findepi
deleted the
findepi/remove-unnecessary-purgedata-parameter-of-trinocatalog-droptable-55fe1f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always same (
true), because Trino doesn't have two flavors ofDROP TABLE.