Add missing query transition to RUNNING state with task-level retries #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Feb 25, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/SqlQueryScheduler.java
Show resolved
Hide resolved
arhimondr
approved these changes
Feb 25, 2022
losipiuk
force-pushed
the
lo/running-state-task
branch
from
68e9d41 to
ad6ae79
Compare
losipiuk
force-pushed
the
lo/running-state-task
branch
from
ad6ae79 to
04ad16f
Compare
findepi
approved these changes
Feb 28, 2022
| @BeforeClass | ||
| public void setUp() | ||
| { | ||
| executorService = listeningDecorator(newCachedThreadPool()); |
|
The first two commit message titles are too long. Notice how GitHub truncates them. |
Yeah I know - I suck at that. I will make them shorter in the other PR this one is based on. |
losipiuk
force-pushed
the
lo/running-state-task
branch
4 times, most recently
from
b687eab to
dd46045
Compare
arhimondr
approved these changes
Mar 1, 2022
losipiuk
force-pushed
the
lo/running-state-task
branch
from
dd46045 to
ad43a37
Compare
losipiuk
force-pushed
the
lo/running-state-task
branch
from
8054a9a to
9f1efdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing query transition to RUNNING state with task-level retries
fix
core query engine
Without the fix queries were stuck in STARTING state for whole execution if task-level retries were enabled.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: