Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify MySqlClient.toColumnMapping #11210

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Simplify MySqlClient.toColumnMapping #11210

merged 1 commit into from
Feb 28, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 27, 2022

refactor.

@findepi
Inline MySqlClient.getUnsignedMapping into toColumnMapping
bbd871c 
It didn't need to be handled separately.
@findepi findepi added the maintenance Project maintenance task label Feb 27, 2022
@findepi findepi requested review from ebyhr and hashhar February 27, 2022 20:45
@cla-bot cla-bot bot added the cla-signed label Feb 27, 2022
@findepi
Copy link
Member Author

findepi commented Feb 27, 2022

cc @tangjiangling

@findepi
Copy link
Member Author

findepi commented Feb 28, 2022

CI #6220 & hdp3 suite-1 failure

@findepi findepi merged commit 5922103 into trinodb:master Feb 28, 2022
@findepi findepi deleted the findepi/inline-mysqlclient-getunsignedmapping-into-tocolumnmapping-160cdd branch February 28, 2022 08:35
@github-actions github-actions bot added this to the 372 milestone Feb 28, 2022
@mosabua mosabua mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed maintenance Project maintenance task
Milestone
372
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @ebyhr @hashhar