Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirection awareness for RENAME COLUMN task #11226

Merged

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Feb 28, 2022

Description

Add redirection awareness for the task:

  • ALTER TABLE XXX RENAME COLUMN

Is this change a fix, improvement, new feature, refactoring, or other?

This is a fix.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

This is a core engine change affecting mainly hive/iceberg connectors.

How would you describe this change to a non-technical end user or system administrator?

In the context of dealing with a shared Hive Metastore Service where tables of different types can co-exist in the metastore, it is helpful for the end-user to perform automatically table redirections when the user is in the context of a hive schema, but is referencing an iceberg table.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Core
* Add redirection awareness for `RENAME COLUMN` task. ({issue}`11226`)

@findinpath findinpath force-pushed the rename-column-redirection-awareness branch from 3e7afb3 to cc2ae5d Compare March 4, 2022 15:31
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. can you please rebase?

@findinpath findinpath force-pushed the rename-column-redirection-awareness branch from cc2ae5d to c45ad6d Compare March 8, 2022 17:06
@findinpath findinpath force-pushed the rename-column-redirection-awareness branch from c45ad6d to 0579e74 Compare March 9, 2022 05:51
@phd3
Copy link
Member

phd3 commented Mar 9, 2022

unrelated #6220

@phd3 phd3 merged commit fcde77f into trinodb:master Mar 9, 2022
@phd3 phd3 mentioned this pull request Mar 9, 2022
@github-actions github-actions bot added this to the 373 milestone Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants