TRY should handle invalid value error in cast VACHAR as TIMESTAMP #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
changed the title
takezoe
force-pushed
the
try_cast_invalid_timestamp
branch
from
a7934c8 to
4b5d21b
Compare
findepi
requested changes
Mar 2, 2022
| .toEpochSecond(); | ||
| } | ||
| catch (DateTimeException e) { | ||
| throw new IllegalArgumentException("Invalid timestamp: " + value, e); |
There was a problem hiding this comment.
Fixed. Is it better to replace another IllegalArgumentException in this method too?
core/trino-main/src/main/java/io/trino/operator/scalar/timestamp/VarcharToTimestampCast.java
Outdated
Show resolved
Hide resolved
takezoe
force-pushed
the
try_cast_invalid_timestamp
branch
from
4b5d21b to
15a4511
Compare
findepi
approved these changes
Mar 2, 2022
Comment on lines
167
to
170
| catch (ZoneRulesException e) { | ||
| throw new TrinoException(INVALID_CAST_ARGUMENT, "Value cannot be cast to timestamp: " + value, e); | ||
| } | ||
| try { |
There was a problem hiding this comment.
Merged into a single try block.
| @@ -70,6 +71,7 @@ public void testExceptions() | |||
| assertFunction(createTryExpression("1/0"), INTEGER, null); | |||
| assertFunction(createTryExpression("JSON_PARSE('INVALID')"), JSON, null); | |||
| assertFunction(createTryExpression("CAST(NULL AS INTEGER)"), INTEGER, null); | |||
| assertFunction(createTryExpression("CAST('0000-00-00' AS TIMESTAMP)"), TIMESTAMP_MILLIS, null); | |||
There was a problem hiding this comment.
add test with timestamp with time zone
- zero day of month
- invalid tz specifier
takezoe
force-pushed
the
try_cast_invalid_timestamp
branch
from
15a4511 to
6d5d136
Compare
martint
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously (at least in 317),
TRY(CAST(xxxx AS TIMESTAMP)returnedNULLfor a timestamp that contains an invalid value like0000-00-00but in the latest Trino, it fails with the following error:Trino's document says:
Therefore, I think TRY should cover this case. This pull request will resurrect the previous behavior which returns
NULLfor invalid values in timestamp.Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: