Skip test-docs job when PR contains release-notes label #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let test-docs run, or skip test-docs run? I think I'm confused. BTW what's the rationale for the change, unless it's obvious? |
|
@findepi "Let test-docs run" is the expected message. We could rephrase it as: "Let test-docs skip when PR contains release-notes label". The motivation is reducing CI queue more as we use the label only for release notes PR that doesn't require the tests at this time. https://github.com/trinodb/trino/pulls?q=is%3Apr+label%3Arelease-notes |
hashhar
approved these changes
Mar 4, 2022
The label is used only for release notes that don't require tests. Another docs-checks job to verify "trino-docs" module would still run.
ebyhr
force-pushed
the
ebi/docs-skip-release-note
branch
from
83ca864 to
58dfcf4
Compare
ebyhr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let test-docs run when PR doesn't contain
release-noteslabel.Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.