Test Hive S3 datalake over proxy #11310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aczajkowski
force-pushed
the
acz/hive_data_lake_over_proxy_test
branch
from
16f902e to
6af27ce
Compare
findepi
reviewed
Mar 4, 2022
...ng/trino-testing-containers/src/main/java/io/trino/testing/containers/BaseTestContainer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/containers/HiveMinioDataLake.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/containers/HiveMinioDataLake.java
Outdated
Show resolved
Hide resolved
testing/trino-testing-containers/src/main/java/io/trino/testing/containers/Httpd.java
Show resolved
Hide resolved
Comment on lines
+27
to
+24
| public class TestHive2OnDataLakeOverProxy | ||
| extends BaseTestHiveOnDataLake |
There was a problem hiding this comment.
How many, and which tests do we run with S3 HTTP proxy?
There was a problem hiding this comment.
I think this is the first one in trino repository. And in this particular case all underlining tests in class will be using S3 (MinIO) over proxy.
There was a problem hiding this comment.
I understand, but the tests actually invoked look like a random selection. For example flush procedure tests.
There was a problem hiding this comment.
Yes that's true. Cause behind my decision is that. I needed:
- Hive Data Lake set up
- test's utilising complex operations on S3 (MinIO).
BaseTestHiveOnDataLake test seems to be perfect fit aside cache flush (which are pretty fast so shouldn't be a big deal).
We could ofcourse sub-select some tests and either replicate them or make separate base class.
But I'm not sure if it's worth. In current setup it's a natural place to add new use cases for hive data lake. And we will have a proof that all of those use cases would work over proxy as well (which i agree might be an overkill 🤷♂️ )
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHive2OnDataLakeOverProxy.java
Outdated
Show resolved
Hide resolved
aczajkowski
force-pushed
the
acz/hive_data_lake_over_proxy_test
branch
2 times, most recently
from
110c38c to
1cdec88
Compare
aczajkowski
force-pushed
the
acz/hive_data_lake_over_proxy_test
branch
from
1cdec88 to
029d9e6
Compare
|
Used to prof and/or assure #11255 works. Seems it's more of testing AWS S3 Cli than Trino. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive data lake over proxy test
Description
Test Hive S3 datalake over proxy
Related issues, pull requests, and links
This PR was introduced to test #11255 And is adding integration test on top of this PR.
Documentation
(X) No documentation is needed.
(V) Sufficient documentation is included in this PR.
(X) Documentation PR is available with #prnumber.
(X) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(V) No release notes entries required.
(X) Release notes entries required with the following suggested text: