Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove information_schema role_authorization_descriptors table #11341

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

dain
Copy link
Member

@dain dain commented Mar 5, 2022

Description

This table is not intended to be implemented by the SQL specification
and are only intended to be used in the SQL views that define the actual
tables in information schema. Supporting this table efficiently requires
a large complex API that is not justified by this minimal value.

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# General
* Remove `information_schema.role_authorization_descriptors` table. ({issue}`11341`)
# SPI
* Remove `listAllRoleGrants` method from  ConnectorMetadata. ({issue}`11341`)

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2022
@dain dain force-pushed the remove-role-authorization-descriptors-table branch 2 times, most recently from dd25ce1 to e2c87ca Compare March 13, 2022 22:58
@dain dain force-pushed the remove-role-authorization-descriptors-table branch 3 times, most recently from 4840979 to dab1e16 Compare May 15, 2022 18:56
@dain dain force-pushed the remove-role-authorization-descriptors-table branch from dab1e16 to 1221551 Compare August 13, 2022 18:53
dain added 2 commits August 30, 2022 09:37
This table is not intended to be implemented by the SQL specification
and are only intended to be used in the SQL views that define the actual
tables in information schema. Supporting this table efficiently requires
a large complex API that is not justified by this minimal value.
This was used exclusively by the removed information_schema
role_authorization_descriptors table.
@dain dain force-pushed the remove-role-authorization-descriptors-table branch from 1221551 to 5f13816 Compare August 30, 2022 16:42
@dain dain merged commit 36cbd9c into trinodb:master Aug 30, 2022
@dain dain deleted the remove-role-authorization-descriptors-table branch August 30, 2022 21:32
@github-actions github-actions bot added this to the 395 milestone Aug 30, 2022
@lhofhansl
Copy link
Member

lhofhansl commented Aug 30, 2022

Hmm... I added this specifically so that an organization can query (via SQL) all the grants they have provided.
What's the alternative (SQL) API for this now?

@dain

@lhofhansl
Copy link
Member

@martint Recommended using that table-name as it was closest to the SQL standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants