Remove trino-delta-lake dependency on trino-hive-hadoop2 #11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up a build when the build is parallel.
findepi
requested review from
nineinchnick,
losipiuk,
alexjo2144,
hashhar and
jirassimok
nineinchnick
approved these changes
Mar 14, 2022
yikf
approved these changes
Mar 14, 2022
alexjo2144
approved these changes
Mar 14, 2022
Praveen2112
reviewed
Mar 14, 2022
| @@ -230,7 +230,7 @@ public DistributedQueryRunner build() | |||
| } | |||
|
|
|||
| HiveMetastore metastore = this.metastore.apply(queryRunner); | |||
| queryRunner.installPlugin(new TestingHivePlugin(metastore, module, cachingDirectoryLister)); | |||
| queryRunner.installPlugin(new TestingHivePlugin(Optional.of(metastore), module, cachingDirectoryLister)); | |||
There was a problem hiding this comment.
We should also restrict invoking populateData if the metastore is null.. we might need to configure it as read-only query runner.
There was a problem hiding this comment.
We should also restrict invoking
populateDataif the metastore is null..
@Praveen2112 why?
anyway, it's always present here anyway
losipiuk
approved these changes
Mar 14, 2022
findepi
deleted the
findepi/remove-trino-delta-lake-dependency-on-trino-hive-hadoop2-d7c890
branch
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up a build when the build is parallel.