Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JDBC method getImportedKeys with empty ResultSet #11472

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

joechu1
Copy link
Member

@joechu1 joechu1 commented Mar 14, 2022

Description

There are client applications that does not handle exceptions for unimplemented functions in a JDBC driver, and returns an error. One example of this is from Issue #8708. This pull request is to implement one of the needed metadata function call with an empty result set so that a client application can proceed with connecting to Trino.

Is this change a fix, improvement, new feature, refactoring, or other?
An improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Client library / JDBC driver

How would you describe this change to a non-technical end user or system administrator?
Improves compatibility with client applications using the Trino JDBC driver

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2022
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Mar 14, 2022
@findepi
Copy link
Member

findepi commented Mar 15, 2022

OK implementation per #8708 (comment)

@findepi findepi merged commit 8095a02 into trinodb:master Mar 15, 2022
@github-actions github-actions bot added this to the 374 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

2 participants