Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information for connection properties in SingleStore documentation #11474

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Mar 14, 2022

Description

Add info for connection parameters via JDBC driver to the configuration section. Identical wording is already used in the SQL Server docs and found helpful there by users.

This will also allow linking to the section in the release notes for 374 where we are changing the driver.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

See above

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@hashhar
Copy link
Member

hashhar commented Mar 14, 2022

Thanks for catching. Seems we missed this and only changed the URL in the TLS section in the PR.

Copy link
Contributor

@grantatspothero grantatspothero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you.

@mosabua
Copy link
Member Author

mosabua commented Mar 14, 2022

Ideally we should get this merged tomorrow latest so I can link to it from the 374 release notes..

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend mentioning the connector name in the PR and the commit title from next time.

@ebyhr ebyhr changed the title Add information for connection properties Add information for connection properties in SingleStore documentation Mar 15, 2022
@ebyhr ebyhr merged commit b216e2c into trinodb:master Mar 15, 2022
@github-actions github-actions bot added this to the 374 milestone Mar 15, 2022
@mosabua mosabua deleted the singlestore branch March 18, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants