Rename module and package from MemSQL to SingleStore #11482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/memsql-to-singlestore
branch
from
74dea86 to
9408721
Compare
hashhar
reviewed
Mar 15, 2022
hashhar
reviewed
Mar 15, 2022
plugin/trino-singlestore/src/test/java/io/trino/plugin/singlestore/SingleStoreQueryRunner.java
Outdated
Show resolved
Hide resolved
hashhar
reviewed
Mar 15, 2022
plugin/trino-singlestore/src/main/java/io/trino/plugin/singlestore/SingleStoreConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/memsql-to-singlestore
branch
from
9408721 to
a330813
Compare
hashhar
approved these changes
Mar 15, 2022
hashhar
force-pushed
the
ebi/memsql-to-singlestore
branch
from
a330813 to
f1c1ff0
Compare
|
I pushed a fix for failed tests, verified everything passes locally. Change is https://github.com/trinodb/trino/pull/11482/files#diff-c8a7eb785c3399d1d0c3a88518918a10c40911ed811c7d2328d9bdffe5a12b62R452-R462 |
hashhar
force-pushed
the
ebi/memsql-to-singlestore
branch
from
f1c1ff0 to
2ad8cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename module and package from MemSQL to SingleStore
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: